-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix OSD speed unit preview #2471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
Have implemented #2146 on user request. The user was from GB and insisted on using km for GPS speed. But it looks like British people are using one or the other depending on birthday? |
|
The actual code was wrong indeed. It was showing bad the units for Metric. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week. |
haslinghuis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared with firmware and you are indeed correct.
My bad it was one of my first code PR's 😃
|
AUTOMERGE: (PASS)
|
The GPS Speed OSD element preview is wrong, depending on the units.
It is showing
km/hfor British, andmp/hfor Imperial and Metric.This PR changes this, using
km/hfor Metric, andmp/hfor Imperial and British, like in the firmware part:https://github.com/betaflight/betaflight/blob/025ee87a7aca068e3659fd066b8a9afbed123361/src/main/osd/osd_elements.c#L492-L505