Skip to content

LAND NOW OSD element (configurator part) #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

LAND NOW OSD element (configurator part) #2492

wants to merge 1 commit into from

Conversation

@limonspb
Copy link
Member

@limonspb limonspb commented May 20, 2021 •
edited
Loading

A separate LAND NOW OSD element in addition to OSD warnings.

Configurator part for this PR:
betaflight/betaflight#10750

and this feature request:
betaflight/betaflight#10667

should be merged after this one:
#2427

@limonspb limonspb mentioned this pull request May 20, 2021
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@mikeller mikeller added this to the 10.8.0 milestone May 20, 2021
@blckmn
Copy link
Member

blckmn commented Jun 10, 2021 •
edited
Loading

AUTOMERGE: (FAIL)

  • Github identifies PR as mergeable -> FAIL
  • PR is not in draft -> FAIL
  • Assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • 'Don't merge' label NOT found -> PASS
  • At least one 'RN:' label found -> PASS
  • 'Tested' label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@limonspb limonspb marked this pull request as draft June 10, 2021 07:19
@ctzsnooze ctzsnooze modified the milestones: 10.8.0, 10.8.1 Dec 22, 2021
@haslinghuis haslinghuis modified the milestones: 10.8.1, 10.9.0 Jun 28, 2022
@limonspb
Copy link
Member Author

limonspb commented Oct 14, 2022

this needs more work and actually a new PR because it will be not just a land now, but a second set of warnings with a bitmask as suggested by Mikeller and Etracer. So i will close this one and lets see if im able to make a PR before the feature freeze.

@limonspb limonspb closed this Oct 14, 2022
@limonspb limonspb deleted the land_now_osd branch November 7, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Needs coordination with firmware RN: IMPROVEMENT

Projects

None yet

Milestone

10.9.0

Development

Successfully merging this pull request may close these issues.

5 participants

@limonspb @blckmn @mikeller @haslinghuis @ctzsnooze