-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Prevent drag/dop and text selection on most elements. #2497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@McGiverGim is there a CSS selector that selects ALL children, not just direct descendants? If so I could improve the selectors a bit. e.g. |
@hydra I don' t understand exactly... something like: tag1 tag2 {
...
}will affect all the tag2 inside a tag1, but it does not need to be a direct descendant. |
haslinghuis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asizon can you confirm, as CSS is your thing 😄
|
I need to fix the OSD drag/drop. Don't merge this yet. I forgot about that. |
Such as OSD elements.
|
@McGiverGim ok, fixed with an additional commit. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
AUTOMERGE: (PASS)
|
Prevent drag/dop and text selection on most elements.
I've noticed, over the years, that it was possible to accidentally start a drag-and-drop operation when clicking various elements in the UI, something that shouldn't be possible and certainly isn't possible in native apps.
Similarly, when selecting text it was possible to accidentally select the text of UI elements, again something that shouldn't be possible unless specifically enabled.
This PR: