Skip to content

Conversation

@McGiverGim
Copy link
Member

As discussed with @chmelevskij and @haslinghuis here: #2468 this PR does a simply refactor of the preview for osd battery usage.

I liked the @chmelevskij idea, but after implementing @haslinghuis one, I think the first is not necessary. It needs to declare some vars that will be used only at some cases of the switch. After using the repeat I think is enough.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis added this to the 10.8.0 milestone Jun 16, 2021
@blckmn
Copy link
Member

blckmn commented Jun 17, 2021

AUTOMERGE: (PASS)

  • Github identifies PR as mergeable -> PASS
  • PR is not in draft -> PASS
  • Assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • 'Don't merge' label NOT found -> PASS
  • At least one 'RN:' label found -> PASS
  • 'Tested' label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@blckmn blckmn merged commit d0e5501 into betaflight:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants