Refactor preview of osd battery usage #2514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @chmelevskij and @haslinghuis here: #2468 this PR does a simply refactor of the preview for osd battery usage.
I liked the @chmelevskij idea, but after implementing @haslinghuis one, I think the first is not necessary. It needs to declare some vars that will be used only at some cases of the switch. After using the
repeatI think is enough.