Skip to content

Change mixer #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2021
Merged

Change mixer #2563

merged 1 commit into from
Sep 1, 2021

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Aug 16, 2021 •
edited
Loading

Changes:

  • enforcement of resetting to the default Quad mixer model to informational
  • add sorting of mixer and escprotocol select fields
  • correct minRange using zeroThrottleValue in case of 3D.

See also betaflight/betaflight#10895 (comment)

Screenshot from 2021-08-18 16-50-14

@haslinghuis haslinghuis added this to the 10.8.0 milestone Aug 16, 2021
@haslinghuis haslinghuis self-assigned this Aug 16, 2021
@haslinghuis haslinghuis force-pushed the mixer-settings branch 7 times, most recently from 700dd00 to d3d9ca1 Compare August 19, 2021 20:24
@haslinghuis
Copy link
Member Author

haslinghuis commented Aug 19, 2021

Fixed remaining code smells

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 19, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis mentioned this pull request Aug 22, 2021
Closed
@blckmn
Copy link
Member

blckmn commented Sep 1, 2021

AUTOMERGE: (PASS)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@blckmn blckmn merged commit 37e41a0 into betaflight:master Sep 1, 2021
@haslinghuis haslinghuis deleted the mixer-settings branch September 1, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@mikeller mikeller mikeller approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@asizon asizon asizon approved these changes

Assignees

@haslinghuis haslinghuis

Labels

RN: BUGFIX Tested

Projects

None yet

Milestone

10.8.0

Development

Successfully merging this pull request may close these issues.

6 participants

@haslinghuis @blckmn @McGiverGim @mikeller @ctzsnooze @asizon