Skip to content

Fixed text for the PID profile reset button. #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2021
Merged

Fixed text for the PID profile reset button. #2622

merged 1 commit into from
Oct 9, 2021

Conversation

@mikeller
Copy link
Member

@mikeller mikeller commented Oct 5, 2021

Fixes #2598.

It's a bit wordy, but concise, making it clear that only the current PID profile is affected:

image

@mikeller mikeller added this to the 10.8.0 milestone Oct 5, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@asizon asizon added the Tested label Oct 9, 2021
@blckmn
Copy link
Member

blckmn commented Oct 9, 2021

AUTOMERGE: (PASS)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@blckmn blckmn merged commit 16acc68 into betaflight:master Oct 9, 2021
@mikeller mikeller deleted the fix_pid_profile_reset_button_text branch October 10, 2021 13:12
@mikeller mikeller modified the milestones: 10.8.0, 10.7.1 Oct 10, 2021
mikeller pushed a commit that referenced this pull request Oct 10, 2021
@blckmn @mikeller
Auto merged - #2622 at Sat, 09 Oct 2021 22:17:06 GMT
e459150 
Fixed text for the PID profile reset button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@klutvott123 klutvott123 klutvott123 approved these changes

@asizon asizon asizon approved these changes

Assignees

@mikeller mikeller

Labels

RN: BUGFIX Tested

Projects

None yet

Milestone

10.7.1

Development

Successfully merging this pull request may close these issues.

"Reset all profiles" doesn't work on Rateprofile settings

5 participants

@mikeller @blckmn @haslinghuis @klutvott123 @asizon