Skip to content

Removed repetitive logging on slider move. #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2021
Merged

Removed repetitive logging on slider move. #2626

merged 1 commit into from
Oct 14, 2021

Conversation

@mikeller
Copy link
Member

@mikeller mikeller commented Oct 10, 2021

Avoids this:

image

@mikeller mikeller added this to the 10.8.0 milestone Oct 10, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.3% 0.3% Duplication

@haslinghuis haslinghuis self-assigned this Oct 10, 2021
@ctzsnooze ctzsnooze self-requested a review October 14, 2021 05:21
@blckmn
Copy link
Member

blckmn commented Oct 14, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 1315fa5 into betaflight:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@klutvott123 klutvott123 klutvott123 approved these changes

Assignees

@haslinghuis haslinghuis

Labels

RN: IMPROVEMENT Tested

Projects

None yet

Milestone

10.8.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mikeller @blckmn @haslinghuis @ctzsnooze @klutvott123