Skip to content

Added internationalisation support for the sliders mode drop down. #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Added internationalisation support for the sliders mode drop down. #2627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions locales/en/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1812,7 +1812,7 @@
"pidTuningFeedforwardAveraging": {
"message": "Averaging"
},
"pidTuningFeedforwardAveragingOptionOff": {
"pidTuningOptionOff": {
"message": "OFF"
},
"pidTuningFeedforwardAveragingOption2Point": {
Expand Down Expand Up @@ -2001,7 +2001,7 @@
"filterWarning": {
"message": "<span class=\"message-negative\"><b>Warning:</b></span> The amount of filtering you are using is dangerously low. This is likely to make the craft hard to control, and can result in flyaways. It is highly recommended that you <b>enable at least one of Gyro Dynamic Lowpass or Gyro Lowpass 1 and at least one of D-Term Dynamic Lowpass or D Term Lowpass 1</b>."
},
"sliderPidsModeSelect": {
"pidTuningSliderPidsMode": {
"message": "Mode:",
"description": "Pidtuning slider mode can be OFF, RP or RPY"
},
Expand Down Expand Up @@ -3970,10 +3970,10 @@
"message": "Axes",
"description": "Iterm Relax Axes selection"
},
"pidTuningItermRelaxAxesOptionRP": {
"pidTuningOptionRP": {
"message": "RP"
},
"pidTuningItermRelaxAxesOptionRPY": {
"pidTuningOptionRPY": {
"message": "RPY"
},
"pidTuningItermRelaxAxesOptionRPInc": {
Expand Down
15 changes: 8 additions & 7 deletions src/tabs/pid_tuning.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,11 +172,12 @@
<div id="slidersPidsBox" class="gui_box grey topspacer tuningPIDSliders">
<table class="pid_titlebar">
<tr>
<th scope="col" class="sm-min">Mode
<th scope="col">
<div i18n="pidTuningSliderPidsMode" class="sm-min"></div>
<select id="sliderPidsModeSelect" class="sliderMode">
<option value="0">OFF</option>
<option value="1">RP</option>
<option value="2">RPY</option>
<option value="0" i18n="pidTuningOptionOff"></option>
<option value="1" i18n="pidTuningOptionRP"></option>
<option value="2" i18n="pidTuningOptionRPY"></option>
</select>
<div class="helpicon cf_tip" i18n_title="pidTuningSliderModeHelp"></div>
</th>
Expand Down Expand Up @@ -612,7 +613,7 @@

<span class="feedforwardOption feedforwardAveraging suboption">
<select id="feedforwardAveraging">
<option i18n="pidTuningFeedforwardAveragingOptionOff" value="0"/>
<option i18n="pidTuningOptionOff" value="0"/>
<option i18n="pidTuningFeedforwardAveragingOption2Point" value="1"/>
<option i18n="pidTuningFeedforwardAveragingOption3Point" value="2"/>
<option i18n="pidTuningFeedforwardAveragingOption4Point" value="3"/>
Expand Down Expand Up @@ -757,8 +758,8 @@

<span class="suboption">
<select id="itermrelaxAxes">
<option i18n="pidTuningItermRelaxAxesOptionRP" value="1">
<option i18n="pidTuningItermRelaxAxesOptionRPY" value="2"/>
<option i18n="pidTuningOptionRP" value="1">
<option i18n="pidTuningOptionRPY" value="2"/>
<option i18n="pidTuningItermRelaxAxesOptionRPInc" value="3"/>
<option i18n="pidTuningItermRelaxAxesOptionRPYInc" value="4"/>
</select>
Expand Down