Skip to content

Split header and fix i18n message #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Split header and fix i18n message #2634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion locales/en/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4003,7 +4003,7 @@
"message": "Absolute Control"
},
"pidTuningAbsoluteControlGainHelp": {
"message": "This feature solves some underlying problems of $t(pidTuningItermRotation.message) and should hopefully replace it at some point. This feature accumulates the absolute gyro error in quad coordinates and mixes a proportional correction into the setpoint. For it to work you need to enable AirMode and $t(pidTuningItermRelax.message) (for $t(pidTuningItermRelaxAxesOptionRP.message)). If you combine this feature with $t(pidTuningIntegratedYaw.message), you can set $t(pidTuningItermRelax.message) enabled for $t(pidTuningItermRelaxAxesOptionRPY.message)."
"message": "This feature solves some underlying problems of $t(pidTuningItermRotation.message) and should hopefully replace it at some point. This feature accumulates the absolute gyro error in quad coordinates and mixes a proportional correction into the setpoint. For it to work you need to enable AirMode and $t(pidTuningItermRelax.message) (for $t(pidTuningOptionRP.message)). If you combine this feature with $t(pidTuningIntegratedYaw.message), you can set $t(pidTuningItermRelax.message) enabled for $t(pidTuningOptionRPY.message)."
},
"pidTuningThrottleBoost": {
"message": "Throttle Boost"
Expand Down
11 changes: 8 additions & 3 deletions src/css/tabs/pid_tuning.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,12 @@
}

.tab-pid_tuning .tuningPIDSliders .pid_titlebar th:first-child {
width: 20%;
width: 6%;
text-align: right;
border-right: none;
}
.tab-pid_tuning .tuningPIDSliders .pid_titlebar th:nth-child(2) {
width: 14%;
border-right: none;
}

Expand All @@ -826,7 +831,7 @@
border-right: none;
}

.tab-pid_tuning .tuningPIDSliders .pid_titlebar th:nth-child(2),
.tab-pid_tuning .tuningPIDSliders .pid_titlebar th:nth-child(3),
.tab-pid_tuning .tuningFilterSliders .pid_titlebar th:nth-child(2) {
width: 30px;
}
Expand Down Expand Up @@ -897,7 +902,7 @@
}

.tab-pid_tuning .subtab-pid .cf_column {
min-width: 472px;
min-width: 600px;
flex: 1;
}

Expand Down
2 changes: 2 additions & 0 deletions src/tabs/pid_tuning.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,8 @@
<tr>
<th scope="col">
<div i18n="pidTuningSliderPidsMode" class="sm-min"></div>
</th>
<th scope="col">
<select id="sliderPidsModeSelect" class="sliderMode">
<option value="0" i18n="pidTuningOptionOff"></option>
<option value="1" i18n="pidTuningOptionRP"></option>
Expand Down