Remove Dynamic Notch from "Features"

[KarateBrot]

General

This is the counterpart to PR betaflight/betaflight#10673

For BF 4.3 / API 1.44 onwards I got rid of the "DYNAMIC_FILTER" switch in the configuration tab. Instead I introduced an on/off switch in the filters tab, so finally all filters can be enabled and disabled from inside the filters tab.

Thanks to @haslinghuis for giving me code that was nearly ready to use. He basically made half of this PR.

Todo

• Wait for rfc filter sliders #2638 to get merged
• Rebase
• Update dyn notch settings layout according to new rfc slider layout style
• Bugfixes
• Mark PR as ready for review

Preview

[haslinghuis]

@KarateBrot this needs a rebase now 😃

[ctzsnooze]

One small comment about the Dynamic Notch switch behaviour.

If Dynamic Notch count is > 0, say '3', and I turn the switch to 'off' (left position), the switch changes colour to grey, but the value for notch count remains unchanged.

Usually 'zero' count = 'off', so I would expect the notch count value to go to '0' the moment I move the slider to the left.

It might be more intuitive to do it like that. If the user decides against turning it off, it would be nice to restore their previous value (unless they saved it at zero).

The value does go to zero after save, but I guess I am suggesting that it should go to zero before the save.

Otherwise it does what it says :-)

[ctzsnooze]

Also, it's a small point, but in other elements, the values are with their labels in the right column, but here the numbers are on the left, squashed in with the switch.

We should be consistent = numbers AND labels to the right (like the rpm filters, immediately above).

This image is with this PR applied over current master.

.

[KarateBrot]

@ctzsnooze Hold onto your horse, lol. But thanks for the feedback anyways. I need to completely rework this now that #2638 is merged (actually haslinghuis has already worked something out for me). I'll have it ready tonight, I think.

[haslinghuis]

Just tested on 4.2.9 and 4.3

[blckmn]

AUTOMERGE: (FAIL)

• github identifies PR as mergeable -> FAIL
• assigned to a milestone -> PASS
• cooling off period lapsed -> PASS
• commit count less or equal to three -> PASS
• Don't merge label NOT found -> PASS
• at least one RN: label found -> PASS
• Tested label found -> PASS
• assigned to an approver -> FAIL
• approver count at least three -> FAIL

[klutvott123]

Tested. Works 👍

[KarateBrot]

I tested it on 4.1, 4.2 and 4.3.

Edit:
Had to push again because I somehow forgot to hide the dynamic notch note on line 3104 in pid_tuning.js when you are using BF >= 4.3

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
7 Code Smells

No Coverage information
0.0% Duplication