Skip to content

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Nov 17, 2021

PR implementing betaflight/betaflight#11043

This PR also makes sure the user only can use (dynamic) idle using the right setup.

PID Tuning tab:
Screenshot from 2021-11-21 21-58-29

Motors tab:
Screenshot from 2021-11-21 21-50-50

"message": "Jitter Reduction"
},
"pidTuningFeedforwardJitterHelp": {
"message": "With this parameter, the Feedforward term can be reduced near the center of the sticks, which results in smoother end of flips and rolls.<br>The value represents a point of stick deflection: 0 - stick centered, 1 - full deflection. When the stick is above that point, Feedforward is kept constant at its configured value. When the stick is positioned below that point, Feedforward is reduced proportionally, reaching 0 at the stick center position.<br>Value of 1 gives maximum smoothing effect, while value of 0 keeps the Feedforward fixed at its configured value over the whole stick range."
Copy link
Member

@ctzsnooze ctzsnooze Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message applies for Transition; jitter reduction is very different and needs a different message. Maybe:
"Jitter reduction reduces Feedforward when the sticks move slowly. This allows smooth, jitter-free flight when making smooth slow arcs, yet provides full feedforward without any delay when the sticks are moved quickly. A higher threshold value (10-12) is more useful for cinematic or HD freestyle purposes, and a slightly lower value (5) better for racing or higher speed RC links."

Copy link
Member Author

@haslinghuis haslinghuis Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. And removed. Decided to put it in a separate PR.

@haslinghuis haslinghuis marked this pull request as draft November 17, 2021 17:07
@haslinghuis haslinghuis force-pushed the rfc_dynamic_idle branch 3 times, most recently from fde01eb to b3989bd Compare November 17, 2021 21:36
@haslinghuis haslinghuis marked this pull request as ready for review November 17, 2021 21:40
@asizon asizon changed the title RFC Dynamic Idle 0RFC Dynamic Idle Nov 18, 2021
@haslinghuis haslinghuis changed the title 0RFC Dynamic Idle RFC Dynamic Idle Nov 18, 2021
@haslinghuis haslinghuis force-pushed the rfc_dynamic_idle branch 2 times, most recently from b2c32c2 to 2e4dbc0 Compare November 21, 2021 20:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@asizon
Copy link
Member

asizon commented Nov 22, 2021

@haslinghuis in my opinion if we are thinking on finally release 4.3, this PR should go in to 10.9.0.

@haslinghuis
Copy link
Member Author

haslinghuis commented Nov 23, 2021

Think we have time for this as 4.3 is not finished (need a firmware PR list), but agree with code freeze / going into release candidate state / finishing up.
Have created a new milestone 10.8.1. Any new PR or unfinished PR's should be transferred to the new milestone.
I like to propose to have minor releases after 10.8.0 release.

@Zuldan
Copy link

Zuldan commented Nov 23, 2021

Getting a Release Candidate for Xmas would be amazing! Bring on the feature freeze!

Copy link
Member

@asizon asizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this hide disable style doesnt go with our other disabled styles arround tabs, but aproved.

@blckmn
Copy link
Member

blckmn commented Nov 27, 2021

AUTOMERGE: (PASS)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@blckmn blckmn merged commit 662ff52 into betaflight:master Nov 27, 2021
@haslinghuis haslinghuis deleted the rfc_dynamic_idle branch November 27, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants