Skip to content

RFC feedforward max_rate_limit and jitter_factor #2656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2021
Merged

RFC feedforward max_rate_limit and jitter_factor #2656

merged 1 commit into from
Nov 25, 2021

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Nov 17, 2021 •
edited
Loading

Needs firmware from betaflight/betaflight#11017

Screenshot from 2021-11-18 02-59-51

@haslinghuis haslinghuis added this to the 10.8.0 milestone Nov 17, 2021
@haslinghuis haslinghuis self-assigned this Nov 17, 2021
@haslinghuis haslinghuis force-pushed the rfc_feedforward_max_rate_limit_and_feedforward_jitter_factor branch 5 times, most recently from 94ab605 to f90b438 Compare November 18, 2021 15:23
@haslinghuis haslinghuis force-pushed the rfc_feedforward_max_rate_limit_and_feedforward_jitter_factor branch from f90b438 to a11c761 Compare November 18, 2021 20:42
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 18, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ctzsnooze ctzsnooze mentioned this pull request Nov 24, 2021
Merged
@ctzsnooze
Copy link
Member

ctzsnooze commented Nov 24, 2021

Checked and tested, works perfectly, thank you @haslinghuis !

@blckmn
Copy link
Member

blckmn commented Nov 24, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@blckmn blckmn merged commit 7e08f9f into betaflight:master Nov 25, 2021
@haslinghuis haslinghuis deleted the rfc_feedforward_max_rate_limit_and_feedforward_jitter_factor branch November 25, 2021 12:31
@haslinghuis haslinghuis mentioned this pull request Nov 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blckmn blckmn blckmn approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@klutvott123 klutvott123 klutvott123 approved these changes

Assignees

@haslinghuis haslinghuis

Labels

Merged Ready to Merge RN: IMPROVEMENT Tested

Projects

None yet

Milestone

10.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@haslinghuis @ctzsnooze @blckmn @klutvott123