Skip to content

Update github issues templates #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2021
Merged

Update github issues templates #2665

merged 1 commit into from
Dec 8, 2021

Conversation

@mathiasvr
Copy link
Contributor

@mathiasvr mathiasvr commented Nov 25, 2021 •
edited
Loading

Remove old github issue template and add new ones based on those in the main betaflight repo.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 25, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mathiasvr mathiasvr mentioned this pull request Nov 25, 2021
Merged
@haslinghuis haslinghuis self-assigned this Dec 4, 2021
@haslinghuis haslinghuis added this to the 10.8.0 milestone Dec 4, 2021
@ctzsnooze ctzsnooze requested a review from blckmn December 4, 2021 00:17
@ctzsnooze
Copy link
Member

ctzsnooze commented Dec 4, 2021

@mathiasvr how do we test this out?

@mathiasvr
Copy link
Contributor Author

mathiasvr commented Dec 4, 2021

@ctzsnooze I made it the default branch at https://github.com/mathiasvr/betaflight-configurator, so you can try creating an issue/pr there to see how it looks.

@ctzsnooze
Copy link
Member

ctzsnooze commented Dec 4, 2021

Good, that works for me. I'm happy that we merge this.

@ctzsnooze
Copy link
Member

ctzsnooze commented Dec 4, 2021

I added the 'tested' label because it looks good. We might not really be able to test proper functionality until after it is merged.

asizon
asizon approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@asizon asizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so good @mathiasvr !

@blckmn
Copy link
Member

blckmn commented Dec 8, 2021

AUTOMERGE: (PASS)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@blckmn blckmn merged commit 173c467 into betaflight:master Dec 8, 2021
@mathiasvr mathiasvr deleted the update-github-issue-template branch February 13, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@limonspb limonspb limonspb approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@asizon asizon asizon approved these changes

@blckmn blckmn Awaiting requested review from blckmn

Assignees

@haslinghuis haslinghuis

Labels

Housekeeping RN: REFACTOR Tested

Projects

None yet

Milestone

10.8.0

Development

Successfully merging this pull request may close these issues.

6 participants

@mathiasvr @ctzsnooze @blckmn @limonspb @haslinghuis @asizon