Skip to content

Make expert mode permanent even after manually switching it off and reconnecting #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Make expert mode permanent even after manually switching it off and reconnecting #2866

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73a3c62
Fix typo
sobelek Mar 21, 2022
a46ff4b
Reload permament expert mode config value when reconnecting
sobelek Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/js/serial_backend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ function initializeSerialBackend() {
$('input.auto_connect, span.auto_connect').prop('title', i18n.getMessage('autoConnectDisabled'));
}

// bind UI hook to auto-connect checkbos
// bind UI hook to auto-connect checkbox
$('input.auto_connect').change(function () {
GUI.auto_connect = $(this).is(':checked');

Expand Down Expand Up @@ -193,6 +193,12 @@ function finishClose(finishedCallback) {
// reset active sensor indicators
sensor_status(0);

// reset expert mode
ConfigStorage.get('permanentExpertMode', function (result) {
const checked = result.permanentExpertMode;
$('input[name="expertModeCheckbox"]').prop('checked', checked).trigger('change');
});
Comment on lines +197 to +200
Copy link
Member

@chmelevskij chmelevskij Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not need to use callback syntax now (we should drop that completely...)

Suggested change
ConfigStorage.get('permanentExpertMode', function (result) {
const checked = result.permanentExpertMode;
$('input[name="expertModeCheckbox"]').prop('checked', checked).trigger('change');
});
const result = ConfigStorage.get('permanentExpertMode');
const checked = result.permanentExpertMode;
$('input[name="expertModeCheckbox"]').prop('checked', checked).trigger('change');

Copy link
Member

@haslinghuis haslinghuis Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chmelevskij will be fixed in #2636

Copy link
Member

@chmelevskij chmelevskij Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, though that one is in already.... soz

Copy link
Member

@chmelevskij chmelevskij Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But wait a minute, master already supports sync access, so wouldn't it be better to just go with the correct usage?

Copy link
Member

@chmelevskij chmelevskij Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/betaflight/betaflight-configurator/blob/master/src/js/ConfigStorage.js#L32


if (wasConnected) {
// detach listeners and remove element data
$('#content').empty();
Expand Down