Fixing a sporadic timing error prevents a backup from being written correctly to a file #2876
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
Do you want to test this code? Here you have an automated build: |
|
AUTOMERGE: (FAIL)
|
|
@mrRobot62 please see also: #2879 |
limonspb
left a comment
limonspb
left a comment
There was a problem hiding this comment.
@mrRobot62 could you please test the latest master and check if we need this fix from you now. Thanks!
| }); | ||
|
|
||
| this.cliEngine.sendLine(CliEngine.s_commandDiffAll); | ||
| this.cliEngine.sendLine(CliEngine.s_commandDumpAll); |
There was a problem hiding this comment.
this should stay Diff not dump. The idea is to actually save diff as it's smaller, faster to save/load and more flexible.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week. |
|
Pull request closed automatically as inactive. |
4 participants
On mac I found a sporadic timing error which prevents to write a complete backup into a file. It must be something with the connection between FC and BF configurator, if there is a delay there, the case occurs
Problem was found here
GUI.interval_add(readingDumpIntervalName, () => { const currentTime = performance.now(); if (currentTime - lastCliStringReceived > 500) { this.cliEngine.unsubscribeOnRowCame(); GUI.interval_remove(readingDumpIntervalName); resolve(diffAll); }Unfortunately increasing 500 to a bigger number do not fix this issue.
Sometimes it returns more or less nothing.
Based on a sporadic error my fix is not high spophisticated. In function
TABS.presets.onSaveConfigClickI check text length, if it is to small, quit function with a warning otherwise write file.Change
diff alltodump allbased on function name which is called.