Skip to content

Move TPA to PID profile #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2022
Merged

Move TPA to PID profile #2988

merged 2 commits into from
Oct 13, 2022

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Aug 7, 2022

@haslinghuis haslinghuis added this to the 10.9.0 milestone Aug 7, 2022
@haslinghuis haslinghuis self-assigned this Aug 7, 2022
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Aug 8, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

limonspb
limonspb previously approved these changes Aug 8, 2022
View reviewed changes
@haslinghuis
Copy link
Member Author

haslinghuis commented Aug 8, 2022

Do we like to move the UI part:

image

@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis force-pushed the update-pidprofile branch 2 times, most recently from c908109 to d310a4f Compare August 8, 2022 21:29
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

This comment has been minimized.

Sign in to view
@limonspb
Copy link
Member

limonspb commented Sep 22, 2022

Do we like to move the UI part:

image

of course! :)
And sonarcloud says there is a bug?

@github-actions

This comment has been minimized.

Sign in to view
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis changed the title Update PID Profile Move TPA to PID profile Oct 13, 2022
@haslinghuis haslinghuis merged commit 2d84e47 into betaflight:master Oct 13, 2022
@haslinghuis haslinghuis deleted the update-pidprofile branch October 13, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@limonspb limonspb limonspb approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@asizon asizon Awaiting requested review from asizon

@klutvott123 klutvott123 Awaiting requested review from klutvott123

Assignees

@haslinghuis haslinghuis

Labels

Needs coordination with firmware Ready to Merge RN: IMPROVEMENT

Projects

None yet

Milestone

10.9.0

Development

Successfully merging this pull request may close these issues.

5 participants

@haslinghuis @blckmn @limonspb @McGiverGim @ctzsnooze