Skip to content

Chore/move gui to modules #3001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2022
Merged

Chore/move gui to modules #3001

merged 1 commit into from
Dec 28, 2022

Conversation

@chmelevskij
Copy link
Member

@chmelevskij chmelevskij commented Aug 19, 2022 •
edited
Loading

  • refactor GUI to be class based
  • use import instead of global where possible
  • use esm module for gui.js

@chmelevskij chmelevskij force-pushed the chore/move-gui-to-modules branch 5 times, most recently from cf48b50 to a37ab86 Compare August 21, 2022 05:43
chmelevskij
chmelevskij commented Aug 21, 2022
View reviewed changes
src/main.html
<script type="text/javascript" src="./js/port_handler.js"></script>
<script type="text/javascript" src="./js/port_usage.js"></script>
<script type="text/javascript" src="./js/serial.js"></script>
<script type="text/javascript" src="./js/gui.js"></script>
Copy link
Member Author

@chmelevskij chmelevskij Aug 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything what needed initialisation gets called with import of main.js

chmelevskij
chmelevskij commented Aug 21, 2022
View reviewed changes
src/tabs/presets/presets.js
@@ -1,4 +1,4 @@
'use strict';
Copy link
Member Author

@chmelevskij chmelevskij Aug 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modules are in strict mode by default

@chmelevskij chmelevskij marked this pull request as ready for review August 21, 2022 05:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@blckmn
Copy link
Member

blckmn commented Aug 21, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@McGiverGim
Copy link
Member

McGiverGim commented Sep 15, 2022

I think I don't receive a mail when changed from draft to ready to review. It seems ok to me.

@haslinghuis haslinghuis added this to the 10.9.0 milestone Sep 15, 2022
@haslinghuis
Copy link
Member

haslinghuis commented Sep 15, 2022

Android build is failing as other builds are cancelled.

@chmelevskij chmelevskij force-pushed the chore/move-gui-to-modules branch from a37ab86 to 91bb2fd Compare December 28, 2022 19:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Dec 28, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit 483dec9 into betaflight:master Dec 28, 2022
@chmelevskij chmelevskij mentioned this pull request Dec 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@chmelevskij chmelevskij

Labels

RN: REFACTOR Tested

Projects

None yet

Milestone

10.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@chmelevskij @blckmn @McGiverGim @haslinghuis