Skip to content

Add no-extra-semi to match what's in sonarcloud #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2022
Merged

Add no-extra-semi to match what's in sonarcloud #3002

merged 1 commit into from
Aug 20, 2022

Conversation

@chmelevskij
Copy link
Member

@chmelevskij chmelevskij commented Aug 19, 2022 •
edited
Loading

Trying to catch it earlier
Screenshot 2022-08-19 at 22 18 11

@chmelevskij chmelevskij marked this pull request as ready for review August 19, 2022 21:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis added this to the 10.9.0 milestone Aug 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Aug 19, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@chmelevskij chmelevskij merged commit b221f2c into betaflight:master Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@limonspb limonspb limonspb approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@chmelevskij chmelevskij

Labels

build system improvement

Projects

None yet

Milestone

10.9.0

Development

Successfully merging this pull request may close these issues.

5 participants

@chmelevskij @blckmn @McGiverGim @limonspb @haslinghuis