Skip to content

Conversation

@limonspb
Copy link
Member

@limonspb limonspb commented Nov 11, 2022

Cherry-pick of this PR:
#3036

This one goes towards 10.8-maintenance.

Now we have 4.4 presets.
4.3 users started seeing 4.4 presets and it confuses them, why multiple presets with the same name? So this is sort of a critical bugfix for 10.8. Any plans for 10.8.1?
@haslinghuis @blckmn @ctzsnooze

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@ctzsnooze
Copy link
Member

Very good point. 4.3 users should only see the 4.3 presets.
Can't comment on the technical side of the PR, but agree entirely with the intent.
Thanks, @limonspb

@limonspb limonspb changed the title Presets bugfix: automatically preselect current FC firmware version 10.8 Presets bugfix: automatically preselect current FC firmware version Nov 12, 2022
@blckmn
Copy link
Member

blckmn commented Nov 14, 2022

Thanks @limonspb I really appreciate you raising this pull request against the maintenance branch. I am actively encouraging everyone to do the same when they have a possible bugfix for a maintenance release.

@blckmn
Copy link
Member

blckmn commented Nov 14, 2022

Also happy to release a 10.8.1 as soon as possible.

@haslinghuis haslinghuis added this to the 10.8.1 milestone Nov 14, 2022
@haslinghuis
Copy link
Member

Don't forget we need to fix this issue:

image

See notes in: #2942

@haslinghuis haslinghuis merged commit f59bfb4 into betaflight:10.8-maintenance Nov 14, 2022
@limonspb
Copy link
Member Author

limonspb commented Nov 14, 2022

Don't forget we need to fix this issue:

image

See notes in: #2942

is that something needed for 10.8.1? somewhere in the code?
I can't understand how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants