Chrome v140 workaround - Replace multiple select in onboard logging

[haslinghuis]

• after chrome version 140 multiple select in onboard logging no longer works.

Summary by CodeRabbit

• New Features
  • Revamped Onboard Logging “Debug Fields” UI: replaced multi-select with per-field checkboxes and real-time enable/disable (changes apply immediately, no save step).
• Refactor
  • Simplified debug-fields population and removed legacy multi-select behavior.
• Style
  • Added a table-based layout inside a styled box and moved the section title into the header for clarity.
• Localization
  • Updated English label: “Data included” → “Debug Fields included”.

[coderabbitai]

Walkthrough

Switches the Blackbox debug-fields selector from a multi-select to a checkbox table UI, updating the bitmask in real time via checkbox changes instead of on Save. Updates the English locale label for the section. Corresponding HTML is restructured to host a table for dynamic rows.

Changes

Cohort / File(s)	Summary
Locale label update locales/en/messages.json	Updated value of onboardLoggingDebugFields from "Data included" to "Debug Fields included".
UI logic refactor to checkbox table src/js/tabs/onboard_logging.js	Removed multi-select logic and Save-time mask aggregation; added createDebugTableRow(i, enabled) to build per-field checkbox rows; populateDebugFields now renders rows; checkboxes update FC.BLACKBOX.blackboxDisabledMask on change; removed sortSelect().multipleSelect() usage.
HTML structure for new UI src/tabs/onboard_logging.html	Replaced select element with a GUI box containing a table body .blackboxDebugFieldsTable for dynamic rows; moved label into spacer_box_title.

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant UI as Debug Fields Table (checkboxes)
  participant BB as FC.BLACKBOX
  participant Save as Save Action

  rect rgb(245,245,255)
    note right of UI: New flow: real-time updates
    U->>UI: Toggle checkbox for field i
    UI->>BB: Update blackboxDisabledMask bit i (set/clear)
    UI-->>U: Checkbox reflects current state
  end

  rect rgb(245,255,245)
    note right of Save: Save persists current mask
    U->>Save: Click "Save Settings"
    Save->>BB: Read current blackboxDisabledMask
    Save-->>U: Save complete
  end

Loading

sequenceDiagram
  participant U as User
  participant MS as Multi-select (old)
  participant BB as FC.BLACKBOX
  participant Save as Save Action

  note right of MS: Old flow (removed)
  U->>MS: Select/deselect fields
  U->>Save: Click "Save Settings"
  Save->>MS: Read selected options
  Save->>BB: Compute and assign blackboxDisabledMask
  Save-->>U: Save complete

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Fix for Chromium v140 select issue #4597 — touches the sortSelect/multi-select UI used previously; related because this PR removes that multi-select usage.

Suggested reviewers

• nerdCopter
• Quick-Flash
• blckmn

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 05bcac8 and 4574e92.

📒 Files selected for processing (3)

• locales/en/messages.json (1 hunks)
• src/js/tabs/onboard_logging.js (2 hunks)
• src/tabs/onboard_logging.html (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

• locales/en/messages.json
• src/tabs/onboard_logging.html
• src/js/tabs/onboard_logging.js

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Pre-merge checks

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description only states that Chrome v140 broke the multiple-select and includes a screenshot, but it does not follow the repository's description template and is missing important reviewer information such as reproduction steps, expected vs actual behavior, a brief summary of what files/changes address the issue, test or CI results, and any linked issue numbers, so reviewers cannot fully assess risk or completeness.	Please expand the PR description to follow the repository template: include a concise summary of the change, clear steps to reproduce and the expected versus actual behavior, a short note of which files or approach were changed, how it was tested and CI status (or test instructions), and any related issue numbers; remove any leftover template text and confirm the target branch.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "Chrome v140 workaround - Replace multiple select in onboard logging" clearly and succinctly states the primary change: replacing the multi-select used in onboard logging as a workaround for Chrome v140; it directly matches the changes in the PR (multi-select → per-field checkboxes) and is specific enough for a teammate scanning history.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Preview URL: https://4574e923.betaflight-configurator.pages.dev

[nerdCopter]

nice