Skip to content

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Sep 25, 2025

Summary by CodeRabbit

  • New Features
    • Adds clear labels for GPS Rescue Throttle PID debug values, improving readability in the debug view.
    • Displays metrics including Throttle P, D, I, Altitude, Target Altitude, Tilt Adjustment, and pre-smoothing D.
    • Automatically available on supported firmware versions (API 1.46+), with no changes required from users.

@haslinghuis haslinghuis added this to the 2025.12 milestone Sep 25, 2025
@haslinghuis haslinghuis self-assigned this Sep 25, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 25, 2025

Walkthrough

Adds a new DEBUG.fieldNames entry for GPS_RESCUE_THROTTLE_PID in src/js/debug.js, gated by API version >= 1.46. Provides labels for debug[all] and debug[0]–debug[7] covering throttle PID components and related metrics. No other logic changes.

Changes

Cohort / File(s) Summary
Debug label mapping update
src/js/debug.js
Introduces GPS_RESCUE_THROTTLE_PID in DEBUG.fieldNames (within update()), active when API >= 1.46, defining labels for debug[all], debug[0]debug[7] for GPS Rescue throttle PID metrics.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is entirely missing and does not include any of the required sections from the repository’s template, leaving reviewers without context, motivation, or testing instructions for the change. Please provide a complete pull request description by removing the placeholder template text and adding sections for a summary of changes, motivation, testing instructions, and any relevant issue references as specified in the description template.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title “Add missing GPS Rescue Throttle PID debug fields” precisely captures the primary change of introducing new debug field mappings for the GPS Rescue Throttle PID in debug.js, and it is concise and specific without extraneous detail. It matches the main content of the diff and provides clear context for reviewers.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@haslinghuis haslinghuis moved this to App in 2025.12.0 Sep 25, 2025
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Preview URL: https://pr4630.betaflight-app.pages.dev

@haslinghuis haslinghuis changed the title Add missing GPS Rescue Throttle PID fields Add missing GPS Rescue Throttle PID debug fields Sep 25, 2025
@haslinghuis haslinghuis merged commit c5e676f into betaflight:master Sep 25, 2025
7 checks passed
@haslinghuis haslinghuis deleted the gps-rescue-throttle-pid branch September 25, 2025 19:26
@github-project-automation github-project-automation bot moved this from App to Done in 2025.12.0 Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants