Skip to content

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Sep 25, 2025

Summary by CodeRabbit

  • Refactor

    • Updated internal rendering dependency to a bundled local implementation, reducing reliance on external sources. This enhances stability, build reliability, and resilience against upstream changes. No user-facing behavior changes expected.
  • Chores

    • Improved dependency management to minimize external breakpoints and support more predictable builds (including offline/air‑gapped environments). No configuration or workflow changes required for end-users.

@haslinghuis haslinghuis added this to the 2025.12 milestone Sep 25, 2025
@haslinghuis haslinghuis self-assigned this Sep 25, 2025
@haslinghuis haslinghuis moved this to App in 2025.12.0 Sep 25, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 25, 2025

Walkthrough

The import path for Renderable components in src/js/utils/three/CanvasRenderer.js was switched from an external three/examples module to a local ./Projector module. No other code, logic, or exports were modified.

Changes

Cohort / File(s) Summary
Import source update
src/js/utils/three/CanvasRenderer.js
Changed import of Renderable entities from three/examples/jsm/renderers/Projector to local ./Projector. No logic or API changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

Cleanup

Suggested reviewers

  • VitroidFPV
  • nerdCopter

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description Check ⚠️ Warning No pull request description has been provided so there is no summary of what was changed or why, and it does not follow the repository’s contribution guidelines. This omission makes it difficult for reviewers to assess the intent, scope, and impact of the change. Add a complete description using the repository template by summarizing the change, explaining why it was made, describing how it was tested, and linking any related issues or bug reports.
Title Check ❓ Inconclusive The title “Fix THREE import” indicates that an import from the three.js library was corrected but is too generic to convey which file or module was updated. Reviewers may not immediately understand the scope or context of the change from this broad phrasing alone. Please refine the title to specify the affected file or module, for example “Use local Projector import in CanvasRenderer.js” to clearly communicate the core change.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1960bd9 and 3fd71c8.

📒 Files selected for processing (1)
  • src/js/utils/three/CanvasRenderer.js (1 hunks)
🔇 Additional comments (1)
src/js/utils/three/CanvasRenderer.js (1)

2-2: Local Projector exports are aligned. The file src/js/utils/three/Projector.js exports Projector, RenderableSprite, RenderableLine, and RenderableFace as named exports.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Preview URL: https://pr4631.betaflight-app.pages.dev

@haslinghuis haslinghuis merged commit 593ef30 into betaflight:master Sep 25, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from App to Done in 2025.12.0 Sep 25, 2025
@haslinghuis haslinghuis deleted the fix-three-import branch September 25, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants