Skip to content

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Oct 2, 2025

Summary by CodeRabbit

  • New Features
    • Added a MAVLink Telemetry debug mode, allowing users to inspect telemetry data either collectively or by individual index.
    • Updated debug labels to clearly present MAVLink Telemetry fields in the UI and logs, improving readability during troubleshooting.
    • Expanded the available debug modes list to include MAVLink Telemetry, making it easier to diagnose connectivity and data flow issues.

@haslinghuis haslinghuis added this to the 2025.12 milestone Oct 2, 2025
@haslinghuis haslinghuis self-assigned this Oct 2, 2025
@haslinghuis haslinghuis moved this to App in 2025.12.0 Oct 2, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

Walkthrough

Added a new debug mode MAVLINK_TELEMETRY to DEBUG.modes and mapped its labels in DEBUG.fieldNames within src/js/debug.js.

Changes

Cohort / File(s) Summary
Debug modes update
src/js/debug.js
Appended MAVLINK_TELEMETRY to DEBUG.modes; added MAVLINK_TELEMETRY entries to DEBUG.fieldNames with labels for debug[all] and debug[i].

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • nerdCopter
  • VitroidFPV

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description does not follow the repository’s template and is missing key sections such as a clear summary of changes, testing instructions, issue references, and confirmation that template instructions have been removed, making it incomplete. Please update the description to fully adopt the provided template by removing template instructions, adding a concise summary of the changes, test and build verification steps, related issue references, and any other required details.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly and concisely summarizes the primary change by stating the addition of the MAVLink Telemetry debug mode, which matches the changes in src/js/debug.js without extraneous detail or ambiguity.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d5a3604 and 6d6dd06.

📒 Files selected for processing (1)
  • src/js/debug.js (2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/js/debug.js (1)
src/js/utils/array.js (1)
  • addArrayElement (65-69)
🔇 Additional comments (2)
src/js/debug.js (2)

851-851: LGTM!

The addition of MAVLINK_TELEMETRY to the debug modes array follows the established pattern and is correctly placed within the API version 1.47 conditional block.


923-929: LGTM!

The field name mappings for MAVLINK_TELEMETRY are correctly structured and follow the established pattern used by other debug modes. The labels are descriptive and appropriate for telemetry debugging.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Preview URL: https://pr4645.betaflight-app.pages.dev

@haslinghuis haslinghuis requested a review from VitroidFPV October 2, 2025 15:20
@blckmn blckmn merged commit 525cae4 into betaflight:master Oct 3, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from App to Done in 2025.12.0 Oct 3, 2025
@haslinghuis haslinghuis deleted the mavlink-telemetry-debug branch October 3, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants