Skip to content

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Oct 5, 2025

Summary by CodeRabbit

  • New Features
    • Expanded telemetry baud rate options. When connected to devices with API v1.47 or higher, users can now select 230400 and 460800 for telemetry configurations, enabling higher-speed communication where supported.

@haslinghuis haslinghuis added this to the 2025.12 milestone Oct 5, 2025
@haslinghuis haslinghuis self-assigned this Oct 5, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 5, 2025

Walkthrough

The change enhances the list of selectable telemetry baud rates in the file src/js/tabs/ports.js. For API versions 1.47 or higher, the available telemetry baud rates now include "230400" and a new "460800" option, expanding the prior selection. No public API or function signatures are altered.

Changes

Cohort / File(s) Change Summary
Telemetry Baud Rate Options Update
src/js/tabs/ports.js
Expanded telemetryBaudRates array for API >= 1.47 to include "230400" and "460800"; no logic flow changes.

Sequence Diagram(s)

sequenceDiagram
    participant UI
    participant PortsConfig (src/js/tabs/ports.js)
    participant API

    UI->>PortsConfig: Request available telemetry baud rates
    PortsConfig-->>API: Get API version
    API-->>PortsConfig: Return API version (e.g., 1.47+)
    PortsConfig-->>UI: Return telemetryBaudRates (incl. 230400, 460800 for 1.47+)
    UI->>User: Display expanded baud rates
    Note over PortsConfig: "230400" and "460800" now included if API >= 1.47
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5-10 minutes

Suggested reviewers

  • VitroidFPV
  • nerdCopter
  • blckmn

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is entirely missing and does not follow the required template, so key information such as the rationale, change summary, testing instructions, and relevant references are absent. Please add a description that follows the repository’s template, including important considerations, a clear summary of the changes, the motivation or rationale, any linked issues, and instructions for testing.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly and succinctly describes the main change of this pull request, which is adding support for the 460.8K telemetry baud rate, and it directly reflects the modifications made without extraneous information.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e65dc56 and 0f87c2c.

📒 Files selected for processing (1)
  • src/js/tabs/ports.js (1 hunks)
🔇 Additional comments (1)
src/js/tabs/ports.js (1)

99-102: LGTM! Clean implementation of higher baud rate support.

The addition of 230400 and 460800 baud rates for telemetry is correctly gated behind the API version check and follows the same pattern used for GPS baud rates. Both are standard, widely-supported baud rates.

Minor note: The PR title mentions "460K8" which appears to be a typo—the actual value "460800" is correct in the code.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2025

@haslinghuis haslinghuis merged commit 0db0774 into betaflight:master Oct 5, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from App to Done in 2025.12.0 Oct 5, 2025
@haslinghuis haslinghuis deleted the tlm-baudrate branch October 5, 2025 16:55
@coderabbitai coderabbitai bot mentioned this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants