Skip to content

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Oct 14, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Stopped automatic redirect to the firmware flasher tab when attempting to open restricted tabs during an active connection. Navigation now remains on your current tab until you choose to switch, preventing surprise tab changes and preserving ongoing workflows.
    • Improves stability of the connection flow by relying on user-driven navigation, reducing accidental flasher launches and unintended context switches.

@haslinghuis haslinghuis added this to the 2025.12 milestone Oct 14, 2025
@haslinghuis haslinghuis self-assigned this Oct 14, 2025
@haslinghuis haslinghuis moved this to App in 2025.12.0 Oct 14, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 14, 2025

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description consists only of a single line referencing another PR and does not follow the repository’s required template; it lacks sections such as a summary of changes, motivation, testing instructions, CI status, and issue references. Please update the description to follow the repository’s template by adding a clear summary of the change, motivation, testing steps, CI status, and any related issue references, and remove or replace the placeholder template text.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly describes the primary change by indicating that the firmware flasher tab will no longer be triggered twice, which directly matches the code modifications removing the duplicate tab activation logic.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ecb566 and c78f644.

📒 Files selected for processing (1)
  • src/js/main.js (0 hunks)
💤 Files with no reviewable changes (1)
  • src/js/main.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving based on #4661 testing

@haslinghuis haslinghuis merged commit cba81c4 into betaflight:master Oct 18, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from App to Done in 2025.12.0 Oct 18, 2025
@haslinghuis haslinghuis deleted the fix-triggering-twice branch October 18, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants