Skip to content

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented May 19, 2022

@haslinghuis
Copy link
Member Author

At least configurator still needs 0.62.0 as it's not working with 0.64.0 (on Linux):

Screenshot from 2022-05-20 01-02-27

@blckmn
Copy link
Member

blckmn commented May 20, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@asizon
Copy link
Member

asizon commented May 20, 2022

At least configurator still needs 0.62.0 as it's not working with 0.64.0 (on Linux):

Screenshot from 2022-05-20 01-02-27

Nwjs game is started!! @haslinghuis

@McGiverGim
Copy link
Member

If I'm not wrong, 0.62 had the problem with the square in the drag&drop, and now 0.64 has going worst? Maybe something related to opengl acceleration? Can you try to disable it with --disable-gpu to see if the issue is fixed?

@haslinghuis
Copy link
Member Author

Configurator on Windows (with or without --disable-gpu):
image

With PR 2916 + NWjs 0.64 is perfect now:
image

@McGiverGim
Copy link
Member

With 2916 + 0.62 the problem is there under Windows or it needs the 0.64 too? Have you tested the --disable-gpu under Linux?

In my Windows I've never seen the OSD as in your capture.

@haslinghuis
Copy link
Member Author

haslinghuis commented May 20, 2022

On Windows 0.62 is ok, But with 0.64 it needs your fixes in 2916.

Have to find the icon in Linux. It doesn't create one if I install my local release, So will create a PR to grab the release from there.

EDIT: Found a solution. Will do a PR for configurator soon but needs 2916 in first.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

@haslinghuis haslinghuis marked this pull request as draft June 20, 2022 11:09
@haslinghuis haslinghuis force-pushed the update-nwjs-to-0-64-0 branch from 789e3bf to 7942976 Compare June 20, 2022 14:14
@haslinghuis haslinghuis changed the title Bump NW.js and ffpmeg to 0.64.0 Bump NW.js and ffpmeg library to 0.65.1 and Node to 18.3.0 Jun 20, 2022
@haslinghuis haslinghuis marked this pull request as ready for review June 20, 2022 14:28
@haslinghuis haslinghuis force-pushed the update-nwjs-to-0-64-0 branch 2 times, most recently from be5a675 to 7c56f02 Compare June 20, 2022 21:23
@haslinghuis haslinghuis changed the title Bump NW.js and ffpmeg library to 0.65.1 and Node to 18.3.0 Bump NW.js and ffpmeg library to 0.62.2 and Node to 16.15.1 Jun 20, 2022
@haslinghuis haslinghuis force-pushed the update-nwjs-to-0-64-0 branch 2 times, most recently from 78dda78 to 279ca4e Compare June 20, 2022 22:02
@haslinghuis haslinghuis force-pushed the update-nwjs-to-0-64-0 branch from 279ca4e to b674148 Compare June 20, 2022 22:11
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis merged commit c1a3a3b into betaflight:master Jun 29, 2022
@haslinghuis haslinghuis deleted the update-nwjs-to-0-64-0 branch June 29, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants