Skip to content

Conversation

@ctzsnooze
Copy link
Member

The recent fields update doesn't work because flightlog_fielddefs.js was not updated, so GPS_RESCUE_HEADING and GPS_RESCUE_HEADING logs were not displaying correct debug or field names.

Also the GHST_MSP and RX_STATE_TIME debug fields were not considered.

Works properly now with GPS_RESCUE_HEADING, GPS_RESCUE_TRACKING and GPS_RESCUE_HEADING debugs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
Betaflight-Blackbox-Explorer-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Sep 13, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@toddferrante
Copy link

Windows: Be sure to uninstall previous version before installing this one. On my first try I installed the new version over the old one. This causes the software to hang and not start up. Needed to kill it in the task manager.

@haslinghuis haslinghuis added this to the 3.7.0 milestone Sep 13, 2022
@haslinghuis haslinghuis merged commit be22a79 into betaflight:master Sep 13, 2022
@haslinghuis
Copy link
Member

@toddferrante having rebased #591 please test

@ctzsnooze ctzsnooze deleted the fix-field-defs-and-graphs-for-GPS-Rescue-4.4 branch September 27, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants