Skip to content

Fix BaroAlt decoding #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix BaroAlt decoding #612

wants to merge 1 commit into from

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Nov 28, 2022

Fixes: #611

@haslinghuis haslinghuis added this to the 3.7.0 milestone Nov 28, 2022
@haslinghuis haslinghuis self-assigned this Nov 28, 2022
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Nov 28, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

McGiverGim
McGiverGim previously approved these changes Nov 28, 2022
View reviewed changes
@haslinghuis haslinghuis force-pushed the fix-baro branch 2 times, most recently from a845d24 to ebbc6c8 Compare November 28, 2022 20:34
@github-actions

This comment has been minimized.

Sign in to view
@KarateBrot
Copy link
Member

KarateBrot commented Dec 2, 2022 •
edited
Loading

I think we should rather fix this naming error in the BF firmware. (BaroAlt to baroAlt)

@haslinghuis
Copy link
Member Author

haslinghuis commented Dec 2, 2022

Sure have looked, but grep didn't find it?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
Betaflight-Blackbox-Explorer-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@KarateBrot
Copy link
Member

KarateBrot commented Dec 2, 2022 •
edited
Loading

The corresponding line is in src/main/blackbox/blackbox.c - line 220

I checked and it should be fixed by now. See https://github.com/betaflight/betaflight/pull/11911/files#diff-97bfca89118cc758fd1576b948ef1cbb5f5f03b4c309cd8236af75a776ca22d1R220

Did the author of the issue maybe use a log that was recorded with an old master on accident?

@haslinghuis
Copy link
Member Author

haslinghuis commented Dec 2, 2022

Using old BBL was not aware of the change.

@haslinghuis haslinghuis closed this Dec 2, 2022
@haslinghuis haslinghuis deleted the fix-baro branch December 2, 2022 04:01
@KarateBrot
Copy link
Member

KarateBrot commented Dec 2, 2022 •
edited
Loading

I think we are not using semver for the blackbox viewer (for whatever reason)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

Assignees

@haslinghuis haslinghuis

Labels

bugfix Ready to merge

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

BBE 3.7.0 Nightly does not decode BaroAlt

4 participants

@haslinghuis @blckmn @KarateBrot @McGiverGim