Skip to content

Conversation

@bonchan
Copy link
Contributor

@bonchan bonchan commented Nov 30, 2022

GPX files can be imported in google earth pro to show a 3d view of the flight to achieve something like this.

Instructions here

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@bonchan bonchan marked this pull request as ready for review November 30, 2022 18:21
@haslinghuis haslinghuis added this to the 3.7.0 milestone Nov 30, 2022
@blckmn
Copy link
Member

blckmn commented Nov 30, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

haslinghuis
haslinghuis previously approved these changes Dec 1, 2022
@github-actions

This comment has been minimized.

haslinghuis
haslinghuis previously approved these changes Dec 1, 2022
haslinghuis
haslinghuis previously approved these changes Dec 1, 2022
@github-actions

This comment has been minimized.

@bonchan bonchan requested a review from KarateBrot December 1, 2022 05:04
@haslinghuis
Copy link
Member

@bonchan please rebase

McGiverGim
McGiverGim previously approved these changes Dec 1, 2022
@McGiverGim
Copy link
Member

Good code! I think you need a rebase :)

@haslinghuis
Copy link
Member

Another reference for this awesome function: https://www.youtube.com/watch?v=uBXmUG6JZkc

@bonchan bonchan dismissed stale reviews from McGiverGim and haslinghuis via 725ab72 December 1, 2022 23:59
@bonchan bonchan force-pushed the 20221127-gpx-exporter branch from 478e6c6 to 725ab72 Compare December 1, 2022 23:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
Betaflight-Blackbox-Explorer-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@bonchan
Copy link
Contributor Author

bonchan commented Dec 2, 2022

@bonchan please rebase

done!

@haslinghuis haslinghuis merged commit 127e76b into betaflight:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants