fix pr 819 breakage - this reverts returning samples, not splice of samples.

[nerdCopter]

graph_spectrum_calc.js:

  return {
    samples : samples,
    count : samplesCount,
  };

fixes breakage cause by #819

Summary by CodeRabbit

• Refactor
  • Updated the handling of sample data in spectrum calculations to return the full buffer, which may include unused elements beyond the valid sample count. The count of valid samples remains clearly indicated.

[coderabbitai]

Walkthrough

The update changes the behavior of the _getFlightSamplesFreq function in src/graph_spectrum_calc.js, so it now returns the entire pre-allocated samples buffer instead of slicing it to the actual number of valid samples. The count property continues to indicate how many entries in the buffer are valid.

Changes

File(s)	Change Summary
src/graph_spectrum_calc.js	Modified _getFlightSamplesFreq to return the full samples buffer instead of a sliced array.

Poem

A buffer once trimmed, now whole and wide,
With trailing spaces it won’t try to hide.
The count still whispers what’s truly there—
Valid samples, precise and fair.
In memory’s meadow, rabbits leap with glee,
For every byte, from one to “n”, is free!
🐇📊

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/graph_spectrum_calc.js (1)

332-335: Consider adding a clarifying comment about the array structure.

For better code clarity, consider adding a comment to document that the returned samples array contains valid data only up to the count property, with unused elements beyond that.

  return {
    samples : samples,
    count : samplesCount,
+   // Note: samples array is pre-allocated and contains valid data only up to 'count'
  };

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd62b52 and ea922dc.

📒 Files selected for processing (1)

• src/graph_spectrum_calc.js (1 hunks)

🔇 Additional comments (1)

src/graph_spectrum_calc.js (1)

332-335:

✅ Verification successful

Properly reverts to returning the full pre-allocated samples buffer.

This change restores the original behavior of returning the entire pre-allocated samples buffer rather than a sliced version with only valid samples. The count property still indicates how many entries are valid.

Run the following script to check for consistency with other similar functions in this file:

---

🏁 Script executed:

#!/bin/bash
# Description: Verify how other functions in the file handle returning samples arrays

echo "Checking how similar functions return sample arrays:"
rg -A 5 "return \{" src/graph_spectrum_calc.js

Length of output: 1205

---

Approval: Consistent return of full buffer with count

This change correctly restores the original behavior of returning the full pre-allocated samples buffer while indicating valid entries via the count property. In this file, pure-spectrum functions return the full buffer with a count, and slicing is only used when aligning multiple parallel arrays (e.g., vsValues or piderror/setpoint). No further changes are required.

[demvlad]

Does exist some error with slice?
Why we need the big unused memory size?
We never use data array cells with index > samplesCount.
By using the true array size we no need samplesCount variable.

By other hand, there are no error without slice too.
Perhaps, the CodeRabbit agrees with me:).

[nerdCopter]

https://discord.com/channels/868013470023548938/1371508791635476491

i'm open to other fixes., make a PR if another solution is better, more proper.

multiple reports of master broken.

here is log for testing: BTFL_BLACKBOX_LOG_20250510_181940_STELLARH7DEV_killing_lipo_need_voltage_telem.BBL.zip

[demvlad]

multiple reports of master broken.
here is log for testing

@nerdCopter
Thank's for log file. Will check.

[demvlad]

Yes, the simple spectrum does not work.
Will figure it out.

[nerdCopter]

i did not make a branch 🤕

[demvlad]

It looks strange at the first look, but the FFT.simple call hangs with true data size. Will study.
I communicate with one man in discord, who has this issue too.