QMC5883P uses QMC5883 unified driver (for L and P variants)

[haslinghuis]

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Fixed magnetometer hardware detection when upgrading to firmware version 3.3.0 or newer, ensuring correct sensor configuration and preventing erroneous entries in the hardware identification.

[coderabbitai]

Walkthrough

The pull request removes a code path that pushes "QMC5883P" into MAG_HARDWARE for BetaFlight versions >= 3.3.0 in the adjustFieldDefsList function. This change alters the sensor hardware configuration during firmware version transitions without modifying other logic or function signatures.

Changes

Cohort / File(s)	Summary
MAG_HARDWARE sensor removal src/flightlog_fielddefs.js	Removed the push of "QMC5883P" into MAG_HARDWARE for BetaFlight >= 3.3.0 in adjustFieldDefsList

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify the removal of "QMC5883P" doesn't break device compatibility or sensor detection for affected BetaFlight versions
• Confirm this aligns with BetaFlight firmware changes in versions >= 3.3.0 regarding sensor support

Possibly related PRs

• Update MAG_HARDWARE #861: Adds logic to push "QMC5883P" into MAG_HARDWARE for newer firmware, the inverse of the removal in this PR.

Suggested labels

RN: IMPROVEMENT

Suggested reviewers

• nerdCopter

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided by the author, but the template requires substantial information including coding style compliance and other guidelines.	Add a detailed pull request description explaining the change, why QMC5883P now uses the unified QMC5883 driver, and any testing performed.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing QMC5883P from MAG_HARDWARE to use the unified QMC5883 driver instead.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch haslinghuis-patch-1

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02e5a39 and 108867e.

📒 Files selected for processing (1)

• src/flightlog_fielddefs.js (0 hunks)

💤 Files with no reviewable changes (1)

• src/flightlog_fielddefs.js

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Preview URL: https://pr868.betaflight-blackbox.pages.dev