Remove redefined mag_i2c_instance BETAFPVF405

[ot0tot]

Summary by CodeRabbit

• Bug Fixes

  • Fixed magnetometer I2C bus configuration on BETAFPV F405, improving sensor detection and initialization reliability.
  • Resolved conflicting settings that could cause the magnetometer to fail to start.

• Refactor

  • Cleaned up duplicate configuration to ensure consistent behavior across builds.

[coderabbitai]

Walkthrough

Consolidates MAG_I2C_INSTANCE definition in configs/BETAFPVF405/config.h by removing a duplicate and setting the remaining definition to I2CDEV_1.

Changes

Cohort / File(s)	Summary
BETAFPVF405 config macro cleanup configs/BETAFPVF405/config.h	Removed an earlier duplicate MAG_I2C_INSTANCE macro; updated the later MAG_I2C_INSTANCE from I2CDEV_2 to I2CDEV_1 so the file resolves to a single definition: I2CDEV_1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Add optional MAG definitions for BETAFPVF405 and BETAFPVF405_ELRS targets #880 — Also modifies MAG_I2C_INSTANCE in configs/BETAFPVF405/config.h to I2CDEV_1; directly related to resolving macro value/duplication.

Suggested reviewers

• haslinghuis

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ot0tot-patch-1

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or `` to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

configs/BETAFPVF405/config.h (1)

50-50: Heads-up: I2C1 on PB8/PB9 conflicts with PPM/ESCSERIAL on PB8

If MAG (I2C1) is enabled, it competes with RX_PPM_PIN/ESCSERIAL on PB8. Consider adding a clarifying comment to prevent misconfiguration.

Suggested inline comment:

+# NOTE: MAG uses I2C1 (PB8/PB9). Conflicts with PPM/ESCSERIAL on PB8; do not enable simultaneously.
 #define MAG_I2C_INSTANCE I2CDEV_1

Also applies to: 63-65, 77-77, 105-105

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3bd1953 and 274cd96.

📒 Files selected for processing (1)

• configs/BETAFPVF405/config.h (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-06-23T18:43:31.746Z

Learnt from: haslinghuis
PR: betaflight/config#822
File: configs/AXISFLYINGH7MINI/config.h:29-37
Timestamp: 2025-06-23T18:43:31.746Z
Learning: In Betaflight configuration files, feature enablement macros like USE_MAG are build options that can be controlled at compile time, while hardware instance definitions like MAG_I2C_INSTANCE are predefined in board configurations to assist with hardware mapping when those features are enabled at build time.

Applied to files:

• configs/BETAFPVF405/config.h

🔇 Additional comments (2)

configs/BETAFPVF405/config.h (2)

105-105: LGTM: De-dup and remap MAG_I2C_INSTANCE to I2CDEV_1 is correct

Aligns with I2C1 pins defined for this target (PB8/PB9). Removing the duplicate avoids macro redefinition noise.

---

105-105: All MAG_I2C_INSTANCE definitions in configs/BETAFPVF405/config.h are unique

• Verified a single #define MAG_I2C_INSTANCE I2CDEV_1 at line 105 in configs/BETAFPVF405/config.h
• No other MAG_I2C_INSTANCE redefinitions or I2CDEV_2 usages found in that file

No further duplicates or unexpected overrides remain.