Skip to content

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Sep 20, 2025

Reverts #884
More changes required

Summary by CodeRabbit

  • Chores
    • Removed support for the HGLRCF435_AIO hardware target. Builds and configurations for this board are no longer included.
    • Impact: Users relying on this board should remain on a previous release or migrate to a supported target to maintain functionality.
    • No changes affect other boards or features.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 20, 2025

Walkthrough

The pull request removes the entire board configuration header at configs/HGLRCF435_AIO/config.h, eliminating all macros for MCU/board identifiers, feature toggles, peripheral and pin mappings, timers, sensor configurations, and related defaults that defined the HGLRCF435_AIO hardware setup.

Changes

Cohort / File(s) Summary of Changes
Remove HGLRCF435_AIO board config
configs/HGLRCF435_AIO/config.h
Deleted the configuration header, removing all board identifiers, feature flags, peripheral/pin/timer mappings, sensor configs, and related defaults for the HGLRCF435_AIO target.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • ot0tot
  • nerdCopter

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The provided PR description only states "Reverts #884" and "More changes required" and does not follow the repository's required description template; it lacks the mandatory sections such as hardware compliance rationale, checklist items, testing details, branch/source info, and explicit explanation of what "more changes" are or why the revert is needed. Please update the PR description to follow the repository template: include the mandatory review statement, hardware compliance references, a clear rationale for the revert with links to the original PR (#884), a checklist showing test and review status, exact details of the further changes required, and confirmation the PR is from a non-master branch; this information is needed before the review can proceed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Revert "Add HGLRCF435_AIO board"" accurately and concisely describes the primary change in this changeset — a reversion of the previously added HGLRCF435_AIO board configuration — which matches the raw_summary showing removal of the board's public configuration header and related mappings.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-884-HGLRCF435_AIO

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c224bf and b0e2a0f.

📒 Files selected for processing (1)
  • configs/HGLRCF435_AIO/config.h (0 hunks)
💤 Files with no reviewable changes (1)
  • configs/HGLRCF435_AIO/config.h

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@haslinghuis haslinghuis requested a review from a team September 20, 2025 23:28
@ot0tot ot0tot merged commit 217552c into master Sep 22, 2025
2 checks passed
@haslinghuis haslinghuis deleted the revert-884-HGLRCF435_AIO branch September 22, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants