-
Notifications
You must be signed in to change notification settings - Fork 205
Add HGLRC_H743_PRO board #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughAdds a new public board configuration header Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (25)📓 Common learnings📚 Learning: 2025-07-14T16:16:56.822ZApplied to files:
📚 Learning: 2025-07-03T04:33:57.480ZApplied to files:
📚 Learning: 2025-07-03T04:33:57.480ZApplied to files:
📚 Learning: 2025-06-23T18:43:31.746ZApplied to files:
📚 Learning: 2025-07-03T15:17:30.040ZApplied to files:
📚 Learning: 2025-08-22T17:08:23.283ZApplied to files:
📚 Learning: 2025-07-28T16:44:59.686ZApplied to files:
📚 Learning: 2025-08-28T20:45:36.652ZApplied to files:
📚 Learning: 2025-07-23T13:43:50.456ZApplied to files:
📚 Learning: 2025-09-26T16:32:46.694ZApplied to files:
📚 Learning: 2025-06-02T16:16:20.197ZApplied to files:
📚 Learning: 2025-07-14T15:41:14.364ZApplied to files:
📚 Learning: 2025-08-28T20:45:36.652ZApplied to files:
📚 Learning: 2025-09-01T19:58:52.049ZApplied to files:
📚 Learning: 2025-09-01T19:58:52.049ZApplied to files:
📚 Learning: 2025-06-02T16:16:20.197ZApplied to files:
📚 Learning: 2025-05-31T17:01:39.423ZApplied to files:
📚 Learning: 2025-08-21T11:11:19.213ZApplied to files:
📚 Learning: 2025-08-21T11:11:19.213ZApplied to files:
📚 Learning: 2025-07-25T20:06:07.492ZApplied to files:
📚 Learning: 2025-09-26T16:32:46.694ZApplied to files:
📚 Learning: 2025-07-25T20:06:07.492ZApplied to files:
📚 Learning: 2025-05-28T15:45:15.608ZApplied to files:
📚 Learning: 2025-08-20T02:54:58.596ZApplied to files:
🔇 Additional comments (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Mark Haslinghuis <[email protected]>
Co-authored-by: Mark Haslinghuis <[email protected]>
|
|
||
| #define DEFAULT_CURRENT_METER_SOURCE CURRENT_METER_ADC | ||
| #define DEFAULT_VOLTAGE_METER_SOURCE VOLTAGE_METER_ADC | ||
| #define DEFAULT_VOLTAGE_METER_SCALE 210 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the schematic, this should be 168
| #define DEFAULT_VOLTAGE_METER_SCALE 210 | |
| #define DEFAULT_VOLTAGE_METER_SCALE 168 |
| #define BARO_I2C_INSTANCE I2CDEV_1 | ||
| #define MAG_I2C_INSTANCE I2CDEV_2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Baro is on I2C2 in schematic
| #define BARO_I2C_INSTANCE I2CDEV_1 | |
| #define MAG_I2C_INSTANCE I2CDEV_2 | |
| #define BARO_I2C_INSTANCE I2CDEV_2 | |
| #define MAG_I2C_INSTANCE I2CDEV_1 |
| #define SPI3_SCK_PIN PB3 | ||
| #define SPI3_SDI_PIN PB4 | ||
| #define SPI3_SDO_PIN PB2 | ||
| #define FLASH_CS_PIN PA15 | ||
| #define FLASH_SPI_INSTANCE SPI3 | ||
| #define DEFAULT_BLACKBOX_DEVICE BLACKBOX_DEVICE_FLASH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flash uses SDMMC in the schematic. Check this and provided an updated schematic if necessary.
Co-authored-by: ot0tot <[email protected]>
|
I will contact my colleagues and provide the latest schematics. |
Checklist (✓/✕, or y/n)
Summary by CodeRabbit