Skip to content

Adding YAW_MOTORS_REVERSED #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

Adding YAW_MOTORS_REVERSED #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion configs/NBD_INFINITYF4/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
#define DEFAULT_VOLTAGE_METER_SOURCE VOLTAGE_METER_ADC
#define DEFAULT_CURRENT_METER_SCALE 245
#define BEEPER_PWM_HZ 1000
//TODO #define YAW_MOTORS_REVERSED ON
#define YAW_MOTORS_REVERSED 1
Copy link
Member

@haslinghuis haslinghuis Nov 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest simplifying like INVERTED

BEEPER_INVERTED
BUTTON_A_PIN_INVERTED
BUTTON_B_PIN_INVERTED
LEDx_INVERTED
SDCARD_DETECT_INVERTED
RX_SPI_LED_INVERTED

❓

Suggested change
#define YAW_MOTORS_REVERSED 1
#define YAW_MOTORS_REVERSED

Copy link
Member Author

@blckmn blckmn Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different use cases. Your suggested similarities are all pins. This changes mixer behaviour.

Copy link
Member

@haslinghuis haslinghuis Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, IMO there is no need for #define YAW_MOTORS_REVERSED OFF (or 0).

#define DEFAULT_PID_PROCESS_DENOM 1
//TODO #define OSD_VBAT_POS 2388
//TODO #define OSD_TIM_2_POS 2370
Expand Down
2 changes: 1 addition & 1 deletion configs/TRANSTECF405HD/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
#define DEFAULT_VOLTAGE_METER_SOURCE VOLTAGE_METER_ADC
#define DEFAULT_CURRENT_METER_SCALE 179
#define BEEPER_INVERTED
//TODO #define YAW_MOTORS_REVERSED ON
#define YAW_MOTORS_REVERSED 1
//TODO #define OSD_CURRENT_POS 2486
#define SYSTEM_HSE_MHZ 8
#define GYRO_1_SPI_INSTANCE SPI1
2 changes: 1 addition & 1 deletion configs/TRANSTECF411AIO/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
#define DEFAULT_CURRENT_METER_SOURCE CURRENT_METER_ADC
#define DEFAULT_VOLTAGE_METER_SOURCE VOLTAGE_METER_ADC
#define BEEPER_INVERTED
//TODO #define YAW_MOTORS_REVERSED ON
#define YAW_MOTORS_REVERSED 1
//TODO #define OSD_CURRENT_POS 2486
//TODO #define OSD_CRAFT_NAME_POS 2112
#define SYSTEM_HSE_MHZ 8
Expand Down
2 changes: 1 addition & 1 deletion configs/TRANSTECF411HD/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
#define DEFAULT_CURRENT_METER_SOURCE CURRENT_METER_NONE
#define DEFAULT_VOLTAGE_METER_SOURCE VOLTAGE_METER_ADC
#define BEEPER_INVERTED
//TODO #define YAW_MOTORS_REVERSED ON
#define YAW_MOTORS_REVERSED 1
//TODO #define SMALL_ANGLE 90
#define DEFAULT_PID_PROCESS_DENOM 1
#define SYSTEM_HSE_MHZ 8
Expand Down