Added GagiFPV Rates #513
Added GagiFPV Rates #513
Conversation
WalkthroughThree new preset configuration files for FPV freestyle drone rates have been added, each targeting Betaflight firmware versions 4.3, 4.4, and 4.5. Each preset provides base Betaflight rate settings, with optional configurations for Actual rates and a cinematic/HD mode. Additionally, a new file containing a cryptographic hash has been introduced. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PresetSystem
User->>PresetSystem: Selects GagiFPVFreeStyle preset (for 4.3/4.4/4.5)
PresetSystem->>PresetSystem: Apply base Betaflight rates
alt Optional: Actual Rates selected
PresetSystem->>PresetSystem: Apply Actual rates configuration
end
alt Optional: Cinematic/HD selected
PresetSystem->>PresetSystem: Apply Cinematic/HD configuration
end
PresetSystem->>User: Confirm applied rates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (2)
presets/4.4/rates/GagiFPVFreeStyle.txt (1)
1-52: Same observations as the 4.3 copy – file is byte-for-byte identical, so the consolidation & include-path comments apply here as well.presets/4.5/rates/GagiFPVFreeStyle.txt (1)
1-52: Same observations as the 4.3 copy – file is byte-for-byte identical, so the consolidation & include-path comments apply here as well.
🧹 Nitpick comments (1)
presets/4.3/rates/GagiFPVFreeStyle.txt (1)
1-16: Avoid triple-duplication of an identical preset across 4.3/4.4/4.5 directoriesBecause the header already declares support for all three firmware versions, a single copy (e.g. in
presets/4.3/rates/) is sufficient.
Keeping three verbatim files increases future maintenance cost and the risk of the versions drifting.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
index_hash.txt(1 hunks)presets/4.3/rates/GagiFPVFreeStyle.txt(1 hunks)presets/4.4/rates/GagiFPVFreeStyle.txt(1 hunks)presets/4.5/rates/GagiFPVFreeStyle.txt(1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: Jaz7Mutant
PR: betaflight/firmware-presets#512
File: presets/4.5/tune/basher_jazzmutant_tune.txt:118-119
Timestamp: 2025-06-20T20:39:08.723Z
Learning: In Betaflight firmware presets, rates defaults from presets/4.3/rates/defaults.txt are used across multiple firmware versions including 4.5, as the file explicitly declares support for firmware versions 4.3, 4.4, and 4.5. There is no separate defaults.txt file in presets/4.5/rates/ directory.
Learnt from: bensonk
PR: betaflight/firmware-presets#509
File: presets/4.5/osd/bensonk.txt:138-152
Timestamp: 2025-05-25T22:26:17.328Z
Learning: BrainFPV commands in Betaflight preset files are safely ignored on non-BrainFPV flight controllers, making it safe to include them in presets even when they might be applied to different hardware.
Learnt from: Jaz7Mutant
PR: betaflight/firmware-presets#512
File: presets/4.5/tune/basher_jazzmutant_tune.txt:1-8
Timestamp: 2025-06-20T18:08:54.334Z
Learning: In Betaflight firmware preset files, embedded double quotes in metadata fields like TITLE and KEYWORDS (e.g., `5"`, `3" to 5"`, `8"/9"`) are standard and do not need escaping. The preset parser handles this syntax correctly as evidenced by widespread usage throughout the codebase.
presets/4.3/rates/GagiFPVFreeStyle.txt (3)
Learnt from: Jaz7Mutant
PR: #512
File: presets/4.5/tune/basher_jazzmutant_tune.txt:118-119
Timestamp: 2025-06-20T20:39:08.723Z
Learning: In Betaflight firmware presets, rates defaults from presets/4.3/rates/defaults.txt are used across multiple firmware versions including 4.5, as the file explicitly declares support for firmware versions 4.3, 4.4, and 4.5. There is no separate defaults.txt file in presets/4.5/rates/ directory.
Learnt from: bensonk
PR: #509
File: presets/4.5/osd/bensonk.txt:138-152
Timestamp: 2025-05-25T22:26:17.328Z
Learning: BrainFPV commands in Betaflight preset files are safely ignored on non-BrainFPV flight controllers, making it safe to include them in presets even when they might be applied to different hardware.
Learnt from: Jaz7Mutant
PR: #512
File: presets/4.5/tune/basher_jazzmutant_tune.txt:1-8
Timestamp: 2025-06-20T18:08:54.334Z
Learning: In Betaflight firmware preset files, embedded double quotes in metadata fields like TITLE and KEYWORDS (e.g., 5", 3" to 5", 8"/9") are standard and do not need escaping. The preset parser handles this syntax correctly as evidenced by widespread usage throughout the codebase.
presets/4.4/rates/GagiFPVFreeStyle.txt (3)
Learnt from: Jaz7Mutant
PR: #512
File: presets/4.5/tune/basher_jazzmutant_tune.txt:118-119
Timestamp: 2025-06-20T20:39:08.723Z
Learning: In Betaflight firmware presets, rates defaults from presets/4.3/rates/defaults.txt are used across multiple firmware versions including 4.5, as the file explicitly declares support for firmware versions 4.3, 4.4, and 4.5. There is no separate defaults.txt file in presets/4.5/rates/ directory.
Learnt from: bensonk
PR: #509
File: presets/4.5/osd/bensonk.txt:138-152
Timestamp: 2025-05-25T22:26:17.328Z
Learning: BrainFPV commands in Betaflight preset files are safely ignored on non-BrainFPV flight controllers, making it safe to include them in presets even when they might be applied to different hardware.
Learnt from: Jaz7Mutant
PR: #512
File: presets/4.5/tune/basher_jazzmutant_tune.txt:1-8
Timestamp: 2025-06-20T18:08:54.334Z
Learning: In Betaflight firmware preset files, embedded double quotes in metadata fields like TITLE and KEYWORDS (e.g., 5", 3" to 5", 8"/9") are standard and do not need escaping. The preset parser handles this syntax correctly as evidenced by widespread usage throughout the codebase.
presets/4.5/rates/GagiFPVFreeStyle.txt (3)
Learnt from: Jaz7Mutant
PR: #512
File: presets/4.5/tune/basher_jazzmutant_tune.txt:118-119
Timestamp: 2025-06-20T20:39:08.723Z
Learning: In Betaflight firmware presets, rates defaults from presets/4.3/rates/defaults.txt are used across multiple firmware versions including 4.5, as the file explicitly declares support for firmware versions 4.3, 4.4, and 4.5. There is no separate defaults.txt file in presets/4.5/rates/ directory.
Learnt from: bensonk
PR: #509
File: presets/4.5/osd/bensonk.txt:138-152
Timestamp: 2025-05-25T22:26:17.328Z
Learning: BrainFPV commands in Betaflight preset files are safely ignored on non-BrainFPV flight controllers, making it safe to include them in presets even when they might be applied to different hardware.
Learnt from: Jaz7Mutant
PR: #512
File: presets/4.5/tune/basher_jazzmutant_tune.txt:1-8
Timestamp: 2025-06-20T18:08:54.334Z
Learning: In Betaflight firmware preset files, embedded double quotes in metadata fields like TITLE and KEYWORDS (e.g., 5", 3" to 5", 8"/9") are standard and do not need escaping. The preset parser handles this syntax correctly as evidenced by widespread usage throughout the codebase.
🔇 Additional comments (2)
index_hash.txt (1)
1-1: Validateindex_hash.txtis regenerated by the CI tooling, not hand-editedIf this hash is meant to reflect the state of the preset index, commit it only through the prescribed
make index(or equivalent) automation. A stale or manually-altered value silently breaks integrity checks.presets/4.3/rates/GagiFPVFreeStyle.txt (1)
18-18: Hard-coded include path may break if directory layout changes
#$ INCLUDE: presets/4.3/rates/defaults.txtrelies on an absolute path from repo root.
Confirm this is the accepted convention; otherwise prefer a relative include (../defaults.txt) to keep the file relocatable.
|
please read this doc:
|
2 participants
Important considerations when opening a pull request:
Make sure you do not make the changes you want to open a pull request for on the
masterbranch of your fork, or open the pull request from themasterbranch of your fork. Some of our integrations will fail if you do this, resulting in your pull request not being accepted. If this is your first pull request, it is probably a good idea to first read up on how opening pull requests work (https://opensource.com/article/19/7/create-pull-request-github is a good introduction);Pull requests will only be accepted if they are opened against the
masterbranch of our repository. Pull requests opened against other branches without prior consent from the maintainers will be closed;Please follow the coding style guidelines: https://github.com/betaflight/betaflight/blob/master/docs/development/CodingStyle.md
Keep your pull requests as small and concise as possible. One pull request should only ever add / update one feature. If the change that you are proposing has a wider scope, consider splitting it over multiple pull requests. In particular, pull requests that combine changes to features and one or more new targets are not acceptable.
Ideally, a pull request should contain only one commit, with a descriptive message. If your changes use more than one commit, rebase / squash them into one commit before submitting a pull request. If you need to amend your pull request, make sure that the additional commit has a descriptive message, or - even better - use
git commit --amendto amend your original commit.All pull requests are reviewed. Be ready to receive constructive criticism, and to learn and improve your coding style. Also, be ready to clarify anything that isn't already sufficiently explained in the code and text of the pull request, and to defend your ideas.
We use continuous integration (CI) with Travis to build all targets and run the test suite for every pull request. Pull requests that fail any of the builds or fail tests will most likely not be reviewed before they are fixed to build successfully and pass the tests. In order to get a quick idea if there are things that need fixing before opening a pull request or pushing an update into an existing pull request, run
make pre-pushto run a representative subset of the CI build. Note: This is not an exhaustive test (which will take hours to run on any desktop type system), so even if this passes the CI build might still fail.If your pull request is a fix for one or more issues that are open in GitHub, add a comment to your pull request, and add the issue numbers of the issues that are fixed in the form
Fixes #<issue number>. This will cause the issues to be closed when the pull request is merged;Remove this Text :).
Summary by CodeRabbit