Fix code scanning alert no. 8: Expression language injection (Spring) #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Expression exp = parser.parseExpression(foo); | ||
| message = (Object) exp.getValue(); | ||
| SimpleEvaluationContext context = SimpleEvaluationContext.forReadWriteDataBinding().build(); | ||
| message = (Object) exp.getValue(context); |
Check failure
Code scanning / CodeQL
Expression language injection (Spring)
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI over 1 year ago
To fix the problem, we need to ensure that the user input is not directly used in a SpEL expression. Instead, we should sanitize the input or avoid using it in a SpEL expression altogether. If using the input in a SpEL expression is necessary, we should use a more restricted evaluation context.
In this case, we will sanitize the input to ensure it does not contain any potentially dangerous characters or expressions. We will also configure the SimpleEvaluationContext to be more restrictive.
Suggested changeset
1
src/main/java/io/shiftleft/controller/SearchController.java
| @@ -23,5 +23,7 @@ | ||
| try { | ||
| // Sanitize user input | ||
| String sanitizedFoo = foo.replaceAll("[^a-zA-Z0-9]", ""); | ||
| ExpressionParser parser = new SpelExpressionParser(); | ||
| Expression exp = parser.parseExpression(foo); | ||
| SimpleEvaluationContext context = SimpleEvaluationContext.forReadWriteDataBinding().build(); | ||
| Expression exp = parser.parseExpression(sanitizedFoo); | ||
| SimpleEvaluationContext context = SimpleEvaluationContext.forReadWriteDataBinding().withInstanceMethods().build(); | ||
| message = (Object) exp.getValue(context); |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/beth-linker/shiftleft-java-demo/security/code-scanning/8
To fix the problem, we need to ensure that the user-provided input is not evaluated in a powerful context that allows arbitrary method invocation. Instead, we should use a
SimpleEvaluationContextthat restricts the capabilities of the SpEL expression.doGetSearchmethod to useSimpleEvaluationContextfor evaluating the SpEL expression.SimpleEvaluationContextis configured to allow only read/write data binding without method invocation.Suggested fixes powered by Copilot Autofix. Review carefully before merging.