Draft
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Better Call v2: Endpoint Type Optimization & API Refactor
Summary
This PR introduces the core architectural changes for Better Call v2. The primary focus is to significantly improve TypeScript compiler performance, enhance type inference for developers, and prune the public API surface to reduce bundle bloat.
Key Changes
1. Refactor
createEndpointGeneric SignatureWe are moving away from the monolithic
Optionsobject in favor of flattened generics.Options extends EndpointOptionsapproach forced the TypeScript compiler to parse a massive, deeply nested object for every endpoint, leading to sluggish IDE performance and slow CI type-checking.Body,Query,Params, etc.Before:
After:
2. API Surface Hardening (Export Cleanup)
export type * from '../*.ts'. This was leaking internal utility types and polluting the consumer's namespace.3. Dead Code Elimination (DCE)
EndpointOptionsandStrictEndpointtypes that were rendered obsolete by the new generic structure.Impact
createEndpoint.Breaking Changes⚠️
createEndpointsignature has changed. Consumers migrating from v1 will need to update their endpoint definitions to the new flattened generic format.