Skip to content

fix: add body stringification for application/json content-type #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryota-iso wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −1
Open

fix: add body stringification for application/json content-type #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/better-fetch/src/test/fetch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,18 @@ describe("fetch", () => {
expect(data?.body).to.deep.eq(message);
});

it("stringifies body when content-type is explicitly application/json", async () => {
const payload = { foo: "bar" };
const { data } = await $echo<any>("/echo", {
method: "POST",
body: payload,
headers: { "Content-Type": "application/json" },
});

expect(data?.body).toEqual(payload);
expect(data?.headers).to.include({ "content-type": "application/json" });
});

it("Bypass URLSearchParams body", async () => {
const data = new URLSearchParams({ foo: "bar" });
const { data: res } = await betterFetch<any>(getURL("post"), {
Expand Down
7 changes: 6 additions & 1 deletion packages/better-fetch/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,12 @@ export function getBody(options?: BetterFetchOption) {
return null;
}
const headers = new Headers(options?.headers);
if (isJSONSerializable(options.body) && !headers.has("content-type")) {
const contentType = headers.get("content-type");
const isJSONContentType = contentType && JSON_RE.test(contentType);
if (
isJSONSerializable(options.body) &&
(!headers.has("content-type") || isJSONContentType)
) {
for (const [key, value] of Object.entries(options?.body)) {
if (value instanceof Date) {
options.body[key] = value.toISOString();
Expand Down