Increase test coverage

Author: rsmithlal

spec/policies/better_together/person_block_policy_spec.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe BetterTogether::PersonBlockPolicy do # rubocop:todo Metrics/BlockLength
+  let(:user) { create(:better_together_user, :confirmed) }
+  let(:agent) { user.person }
+  let(:other) { create(:better_together_person) }
+
+  describe '#index?' do
+    it 'allows signed-in users' do
+      expect(described_class.new(user, BetterTogether::PersonBlock).index?).to be true
+    end
+  end
+
+  describe '#create?' do
+    it 'permits when agent is blocker and blocked is not a platform manager' do
+      record = BetterTogether::PersonBlock.new(blocker: agent, blocked: other)
+      expect(described_class.new(user, record).create?).to be true
+    end
+
+    it 'denies when blocked is a platform manager' do
+      host_platform = create(:better_together_platform, :host, privacy: 'public')
+      manager_user = create(:better_together_user, :confirmed)
+      platform_manager_role = BetterTogether::Role.find_by(identifier: 'platform_manager')
+      BetterTogether::PersonPlatformMembership.create!(
+        joinable: host_platform,
+        member: manager_user.person,
+        role: platform_manager_role
+      )
+
+      record = BetterTogether::PersonBlock.new(blocker: agent, blocked: manager_user.person)
+      expect(described_class.new(user, record).create?).to be false
+    end
+
+    it 'denies when reporter is not the blocker' do
+      record = BetterTogether::PersonBlock.new(blocker: other, blocked: agent)
+      expect(described_class.new(user, record).create?).to be false
+    end
+  end
+
+  describe '#destroy?' do
+    it 'permits when agent is blocker' do
+      record = BetterTogether::PersonBlock.new(blocker: agent, blocked: other)
+      expect(described_class.new(user, record).destroy?).to be true
+    end
+
+    it 'denies when agent is not blocker' do
+      record = BetterTogether::PersonBlock.new(blocker: other, blocked: agent)
+      expect(described_class.new(user, record).destroy?).to be false
+    end
+  end
+end

spec/policies/better_together/report_policy_spec.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe BetterTogether::ReportPolicy do
+  let(:user) { create(:better_together_user, :confirmed) }
+  let(:agent) { user.person }
+  let(:other) { create(:better_together_person) }
+
+  it 'permits create when reporter is agent and reportable is different' do
+    record = BetterTogether::Report.new(reporter: agent, reportable: other, reason: 'spam')
+    expect(described_class.new(user, record).create?).to be true
+  end
+
+  it 'denies create when reporter is not agent' do
+    record = BetterTogether::Report.new(reporter: other, reportable: agent, reason: 'spam')
+    expect(described_class.new(user, record).create?).to be false
+  end
+
+  it 'denies create when reporter equals reportable' do
+    record = BetterTogether::Report.new(reporter: agent, reportable: agent, reason: 'spam')
+    expect(described_class.new(user, record).create?).to be false
+  end
+end

spec/requests/better_together/geography/regions_controller_spec.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'BetterTogether::Geography::RegionsController', type: :request do
+  let(:locale) { I18n.default_locale }
+
+  before do
+    configure_host_platform
+    login('[email protected]', 'password12345')
+  end
+
+  describe 'GET /:locale/.../host/geography/regions' do
+    it 'renders index' do
+      get better_together.geography_regions_path(locale:)
+      expect(response).to have_http_status(:ok)
+    end
+  end
+
+  describe 'GET /:locale/.../host/geography/regions/:id' do
+    let!(:region) { create(:region) }
+
+    it 'renders show' do
+      get better_together.geography_region_path(locale:, id: region.slug)
+      expect(response).to have_http_status(:ok)
+    end
+  end
+end

spec/requests/better_together/geography/settlements_controller_spec.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'BetterTogether::Geography::SettlementsController', type: :request do
+  let(:locale) { I18n.default_locale }
+
+  before do
+    configure_host_platform
+    login('[email protected]', 'password12345')
+  end
+
+  describe 'GET /:locale/.../host/geography/settlements' do
+    it 'renders index' do
+      get better_together.geography_settlements_path(locale:)
+      expect(response).to have_http_status(:ok)
+    end
+  end
+
+  describe 'GET /:locale/.../host/geography/settlements/:id' do
+    let!(:settlement) { create(:settlement) }
+
+    it 'renders show' do
+      get better_together.geography_settlement_path(locale:, id: settlement.slug)
+      expect(response).to have_http_status(:ok)
+    end
+  end
+end

spec/requests/better_together/geography/states_controller_spec.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'BetterTogether::Geography::StatesController', type: :request do
+  let(:locale) { I18n.default_locale }
+
+  before do
+    configure_host_platform
+    login('[email protected]', 'password12345')
+  end
+
+  describe 'GET /:locale/.../host/geography/states' do
+    it 'renders index' do
+      get better_together.geography_states_path(locale:)
+      expect(response).to have_http_status(:ok)
+    end
+  end
+
+  describe 'GET /:locale/.../host/geography/states/:id' do
+    let!(:state) { create(:state) }
+
+    it 'renders show' do
+      get better_together.geography_state_path(locale:, id: state.slug)
+      expect(response).to have_http_status(:ok)
+    end
+  end
+end