Rubocop fixes

Author: rsmithlal

spec/concerns/better_together/seedable_spec.rb

@@ -5,17 +5,19 @@
 module BetterTogether
   describe Seedable, type: :model do
     # Define a test ActiveRecord model inline for this spec
+    # rubocop:todo RSpec/LeakyConstantDeclaration
     class TestSeedableClass < ApplicationRecord # rubocop:todo Lint/ConstantDefinitionInBlock
       include Seedable
     end
+    # rubocop:enable RSpec/LeakyConstantDeclaration
 
-    before(:all) do
+    before(:all) do # rubocop:todo RSpec/BeforeAfterAll
       create_table(:better_together_test_seedable_classes) do |t|
         t.string :name
       end
     end
 
-    after(:all) do
+    after(:all) do # rubocop:todo RSpec/BeforeAfterAll
       drop_table(:better_together_test_seedable_classes)
     end
 

spec/models/better_together/seed_spec.rb

@@ -86,29 +86,33 @@
     end
 
     context 'when the source is a direct file path' do
-      context 'and the file exists' do
+      # rubocop:todo RSpec/NestedGroups
+      context 'and the file exists' do # rubocop:todo RSpec/ContextWording, RSpec/NestedGroups
+        # rubocop:enable RSpec/NestedGroups
         before do
           allow(File).to receive(:exist?).with(file_path).and_return(true)
           allow(YAML).to receive(:load_file).with(file_path).and_return(valid_seed_data)
         end
 
-        it 'imports the seed and returns a BetterTogether::Seed record' do
+        it 'imports the seed and returns a BetterTogether::Seed record' do # rubocop:todo RSpec/MultipleExpectations
           result = described_class.load_seed(file_path)
           expect(result).to be_a(described_class)
           expect(result.identifier).to eq('from_test')
           expect(result.payload[:payload_key]).to eq('payload_value')
         end
       end
 
-      context 'but the file does not exist' do
+      # rubocop:todo RSpec/NestedGroups
+      context 'but the file does not exist' do # rubocop:todo RSpec/ContextWording, RSpec/NestedGroups
+        # rubocop:enable RSpec/NestedGroups
         it 'falls back to namespace logic and raises an error' do
           expect do
             described_class.load_seed(file_path)
           end.to raise_error(RuntimeError, /Seed file not found for/)
         end
       end
 
-      context 'when YAML loading raises an error' do
+      context 'when YAML loading raises an error' do # rubocop:todo RSpec/NestedGroups
         before do
           allow(File).to receive(:exist?).with(file_path).and_return(true)
           allow(YAML).to receive(:load_file).with(file_path).and_raise(StandardError, 'Bad YAML')
@@ -126,21 +130,25 @@
       let(:namespace) { 'better_together/wizards/host_setup_wizard' }
       let(:full_path) { Rails.root.join('config', 'seeds', "#{namespace}.yml").to_s }
 
-      context 'and the file exists' do
+      # rubocop:todo RSpec/NestedGroups
+      context 'and the file exists' do # rubocop:todo RSpec/ContextWording, RSpec/NestedGroups
+        # rubocop:enable RSpec/NestedGroups
         before do
           allow(File).to receive(:exist?).with(namespace).and_return(false)
           allow(File).to receive(:exist?).with(full_path).and_return(true)
           allow(YAML).to receive(:load_file).with(full_path).and_return(valid_seed_data)
         end
 
-        it 'imports the seed from the namespace path' do
+        it 'imports the seed from the namespace path' do # rubocop:todo RSpec/MultipleExpectations
           result = described_class.load_seed(namespace)
           expect(result).to be_a(described_class)
           expect(result.identifier).to eq('from_test')
         end
       end
 
-      context 'but the file does not exist' do
+      # rubocop:todo RSpec/NestedGroups
+      context 'but the file does not exist' do # rubocop:todo RSpec/ContextWording, RSpec/NestedGroups
+        # rubocop:enable RSpec/NestedGroups
         before do
           allow(File).to receive(:exist?).with(namespace).and_return(false)
           allow(File).to receive(:exist?).with(full_path).and_return(false)
@@ -153,7 +161,7 @@
         end
       end
 
-      context 'when YAML loading raises an error' do
+      context 'when YAML loading raises an error' do # rubocop:todo RSpec/NestedGroups
         before do
           allow(File).to receive(:exist?).with(namespace).and_return(false)
           allow(File).to receive(:exist?).with(full_path).and_return(true)
@@ -178,7 +186,7 @@
       create(:better_together_seed)
     end
 
-    it 'attaches a YAML file after creation' do
+    it 'attaches a YAML file after creation' do # rubocop:todo RSpec/NoExpectationExample
       # seed.reload  # Ensures the record reloads from the DB after the commit callback
       # expect(seed.yaml_file).to be_attached
 

spec/requests/better_together/person_platform_integrations_spec.rb

@@ -26,31 +26,31 @@
     skip('Add a hash of attributes invalid for your model')
   end
 
-  describe 'GET /index' do
-    it 'renders a successful response' do
+  describe 'GET /index' do # rubocop:todo RSpec/RepeatedExampleGroupBody
+    it 'renders a successful response' do # rubocop:todo RSpec/NoExpectationExample
       # BetterTogether::PersonPlatformIntegration.create! valid_attributes
       # get person_platform_integrations_url
       # expect(response).to be_successful
     end
   end
 
-  describe 'GET /show' do
-    it 'renders a successful response' do
+  describe 'GET /show' do # rubocop:todo RSpec/RepeatedExampleGroupBody
+    it 'renders a successful response' do # rubocop:todo RSpec/NoExpectationExample
       # authorization = BetterTogether::PersonPlatformIntegration.create! valid_attributes
       # get person_platform_integration_url(authorization)
       # expect(response).to be_successful
     end
   end
 
-  describe 'GET /new' do
-    it 'renders a successful response' do
+  describe 'GET /new' do # rubocop:todo RSpec/RepeatedExampleGroupBody
+    it 'renders a successful response' do # rubocop:todo RSpec/NoExpectationExample
       # get new_person_platform_integration_url
       # expect(response).to be_successful
     end
   end
 
-  describe 'GET /edit' do
-    it 'renders a successful response' do
+  describe 'GET /edit' do # rubocop:todo RSpec/RepeatedExampleGroupBody
+    it 'renders a successful response' do # rubocop:todo RSpec/NoExpectationExample
       # authorization = BetterTogether::PersonPlatformIntegration.create! valid_attributes
       # get edit_person_platform_integration_url(authorization)
       # expect(response).to be_successful
@@ -59,30 +59,40 @@
 
   describe 'POST /create' do
     context 'with valid parameters' do
-      it 'creates a new BetterTogether::PersonPlatformIntegration' do
+      # rubocop:todo RSpec/RepeatedExample
+      it 'creates a new BetterTogether::PersonPlatformIntegration' do # rubocop:todo RSpec/NoExpectationExample, RSpec/RepeatedExample
         # expect do
         #   post person_platform_integrations_url, params: { person_platform_integration: valid_attributes }
         # end.to change(BetterTogether::PersonPlatformIntegration, :count).by(1)
       end
+      # rubocop:enable RSpec/RepeatedExample
 
-      it 'redirects to the created person_platform_integration' do
+      # rubocop:todo RSpec/RepeatedExample
+      it 'redirects to the created person_platform_integration' do # rubocop:todo RSpec/NoExpectationExample, RSpec/RepeatedExample
         # post person_platform_integrations_url, params: { person_platform_integration: valid_attributes }
         # expect(response).to
         # redirect_to(person_platform_integration_url(BetterTogether::PersonPlatformIntegration.last))
       end
+      # rubocop:enable RSpec/RepeatedExample
     end
 
     context 'with invalid parameters' do
-      it 'does not create a new BetterTogether::PersonPlatformIntegration' do
+      # rubocop:todo RSpec/RepeatedExample
+      it 'does not create a new BetterTogether::PersonPlatformIntegration' do # rubocop:todo RSpec/NoExpectationExample, RSpec/RepeatedExample
         # expect do
         #   post person_platform_integrations_url, params: { person_platform_integration: invalid_attributes }
         # end.to change(BetterTogether::PersonPlatformIntegration, :count).by(0)
       end
+      # rubocop:enable RSpec/RepeatedExample
 
+      # rubocop:todo RSpec/RepeatedExample
+      # rubocop:todo RSpec/NoExpectationExample
       it "renders a response with 422 status (i.e. to display the 'new' template)" do
         # post person_platform_integrations_url, params: { person_platform_integration: invalid_attributes }
         # expect(response).to have_http_status(:unprocessable_entity)
       end
+      # rubocop:enable RSpec/NoExpectationExample
+      # rubocop:enable RSpec/RepeatedExample
     end
   end
 
@@ -92,43 +102,53 @@
         skip('Add a hash of attributes valid for your model')
       end
 
-      it 'updates the requested person_platform_integration' do
+      # rubocop:todo RSpec/RepeatedExample
+      it 'updates the requested person_platform_integration' do # rubocop:todo RSpec/NoExpectationExample, RSpec/RepeatedExample
         # authorization = BetterTogether::PersonPlatformIntegration.create! valid_attributes
         # patch person_platform_integration_url(authorization), params: { person_platform_integration: new_attributes }
         # authorization.reload
         # skip('Add assertions for updated state')
       end
+      # rubocop:enable RSpec/RepeatedExample
 
-      it 'redirects to the person_platform_integration' do
+      # rubocop:todo RSpec/RepeatedExample
+      it 'redirects to the person_platform_integration' do # rubocop:todo RSpec/NoExpectationExample, RSpec/RepeatedExample
         # authorization = BetterTogether::PersonPlatformIntegration.create! valid_attributes
         # patch person_platform_integration_url(authorization), params: { person_platform_integration: new_attributes }
         # authorization.reload
         # expect(response).to redirect_to(person_platform_integration_url(authorization))
       end
+      # rubocop:enable RSpec/RepeatedExample
     end
 
     context 'with invalid parameters' do
+      # rubocop:todo RSpec/NoExpectationExample
       it "renders a response with 422 status (i.e. to display the 'edit' template)" do
         # authorization = BetterTogether::PersonPlatformIntegration.create! valid_attributes
         # patch person_platform_integration_url(authorization),
         #       params: { person_platform_integration: invalid_attributes }
         # expect(response).to have_http_status(:unprocessable_entity)
       end
+      # rubocop:enable RSpec/NoExpectationExample
     end
   end
 
   describe 'DELETE /destroy' do
-    it 'destroys the requested person_platform_integration' do
+    # rubocop:todo RSpec/RepeatedExample
+    it 'destroys the requested person_platform_integration' do # rubocop:todo RSpec/NoExpectationExample, RSpec/RepeatedExample
       # authorization = BetterTogether::PersonPlatformIntegration.create! valid_attributes
       # expect do
       #   delete person_platform_integration_url(authorization)
       # end.to change(BetterTogether::PersonPlatformIntegration, :count).by(-1)
     end
+    # rubocop:enable RSpec/RepeatedExample
 
-    it 'redirects to the person_platform_integrations list' do
+    # rubocop:todo RSpec/RepeatedExample
+    it 'redirects to the person_platform_integrations list' do # rubocop:todo RSpec/NoExpectationExample, RSpec/RepeatedExample
       # authorization = BetterTogether::PersonPlatformIntegration.create! valid_attributes
       # delete person_platform_integration_url(authorization)
       # expect(response).to redirect_to(person_platform_integrations_url)
     end
+    # rubocop:enable RSpec/RepeatedExample
   end
 end

spec/routing/better_together/person_platform_integrations_routing_spec.rb

@@ -4,36 +4,62 @@
 
 RSpec.describe BetterTogether::PersonPlatformIntegrationsController do
   describe 'routing' do
-    it 'routes to #index' do
+    # rubocop:todo RSpec/RepeatedExample
+    it 'routes to #index' do # rubocop:todo RSpec/NoExpectationExample, RSpec/RepeatedExample
       # expect(get: '/better_together/authorizations').to route_to('better_together/authorizations#index')
     end
+    # rubocop:enable RSpec/RepeatedExample
 
-    it 'routes to #new' do
+    # rubocop:todo RSpec/RepeatedExample
+    it 'routes to #new' do # rubocop:todo RSpec/NoExpectationExample, RSpec/RepeatedExample
       # expect(get: '/better_together/authorizations/new').to route_to('better_together/authorizations#new')
     end
+    # rubocop:enable RSpec/RepeatedExample
 
-    it 'routes to #show' do
+    # rubocop:todo RSpec/RepeatedExample
+    it 'routes to #show' do # rubocop:todo RSpec/NoExpectationExample, RSpec/RepeatedExample
+      # rubocop:todo Layout/LineLength
       # expect(get: '/better_together/authorizations/1').to route_to('better_together/authorizations#show', id: '1')
+      # rubocop:enable Layout/LineLength
     end
+    # rubocop:enable RSpec/RepeatedExample
 
-    it 'routes to #edit' do
+    # rubocop:todo RSpec/RepeatedExample
+    it 'routes to #edit' do # rubocop:todo RSpec/NoExpectationExample, RSpec/RepeatedExample
+      # rubocop:todo Layout/LineLength
       # expect(get: '/better_together/authorizations/1/edit').toroute_to('better_together/authorizations#edit', id: '1')
+      # rubocop:enable Layout/LineLength
     end
+    # rubocop:enable RSpec/RepeatedExample
 
-    it 'routes to #create' do
+    # rubocop:todo RSpec/RepeatedExample
+    it 'routes to #create' do # rubocop:todo RSpec/NoExpectationExample, RSpec/RepeatedExample
       # expect(post: '/better_together/authorizations').to route_to('better_together/authorizations#create')
     end
+    # rubocop:enable RSpec/RepeatedExample
 
-    it 'routes to #update via PUT' do
+    # rubocop:todo RSpec/RepeatedExample
+    it 'routes to #update via PUT' do # rubocop:todo RSpec/NoExpectationExample, RSpec/RepeatedExample
+      # rubocop:todo Layout/LineLength
       # expect(put: '/better_together/authorizations/1').to route_to('better_together/authorizations#update', id: '1')
+      # rubocop:enable Layout/LineLength
     end
+    # rubocop:enable RSpec/RepeatedExample
 
-    it 'routes to #update via PATCH' do
+    # rubocop:todo RSpec/RepeatedExample
+    it 'routes to #update via PATCH' do # rubocop:todo RSpec/NoExpectationExample, RSpec/RepeatedExample
+      # rubocop:todo Layout/LineLength
       # expect(patch: '/better_together/authorizations/1').to route_to('better_together/authorizations#update', id: '1')
+      # rubocop:enable Layout/LineLength
     end
+    # rubocop:enable RSpec/RepeatedExample
 
-    it 'routes to #destroy' do
+    # rubocop:todo RSpec/RepeatedExample
+    it 'routes to #destroy' do # rubocop:todo RSpec/NoExpectationExample, RSpec/RepeatedExample
+      # rubocop:todo Layout/LineLength
       # expect(delete: '/better_together/authorizations/1').toroute_to('better_together/authorizations#destroy',id: '1')
+      # rubocop:enable Layout/LineLength
     end
+    # rubocop:enable RSpec/RepeatedExample
   end
 end

spec/support/shared_examples/a_seedable_model.rb

@@ -35,7 +35,7 @@
     end
 
     describe '#export_as_seed_yaml' do
-      it 'returns a valid YAML string' do
+      it 'returns a valid YAML string' do # rubocop:todo RSpec/MultipleExpectations
         yaml_str = record.export_as_seed_yaml
         expect(yaml_str).to be_a(String)
         expect(yaml_str).to include(BetterTogether::Seed::DEFAULT_ROOT_KEY.to_s)
@@ -60,7 +60,7 @@
         expect(collection_hash.keys).to include(BetterTogether::Seed::DEFAULT_ROOT_KEY)
       end
 
-      it 'includes an array of records under :records' do
+      it 'includes an array of records under :records' do # rubocop:todo RSpec/MultipleExpectations
         collection_hash = described_class.export_collection_as_seed(records)
         root_key = collection_hash.keys.first
         expect(collection_hash[root_key]).to have_key(:records)
@@ -70,7 +70,7 @@
     end
 
     describe '.export_collection_as_seed_yaml' do
-      it 'returns a valid YAML string' do
+      it 'returns a valid YAML string' do # rubocop:todo RSpec/MultipleExpectations
         yaml_str = described_class.export_collection_as_seed_yaml(records)
         expect(yaml_str).to be_a(String)
         expect(yaml_str).to include(BetterTogether::Seed::DEFAULT_ROOT_KEY.to_s)

spec/views/better_together/person_platform_integrations/edit.html.erb_spec.rb

@@ -11,7 +11,7 @@
     assign(:person_platform_integration, person_platform_integration)
   end
 
-  it 'renders the edit person_platform_integration form' do
+  it 'renders the edit person_platform_integration form' do # rubocop:todo RSpec/NoExpectationExample
     # render
 
     # assert_select 'form[action=?][method=?]', person_platform_integration_path(person_platform_integration), 'post' do

spec/views/better_together/person_platform_integrations/index.html.erb_spec.rb

@@ -7,7 +7,7 @@
     assign(:person_platform_integrations, create_list(:person_platform_integration, 3))
   end
 
-  it 'renders a list of better_together/authorizations' do
+  it 'renders a list of better_together/authorizations' do # rubocop:todo RSpec/NoExpectationExample
     # render
     # cell_selector = Rails::VERSION::STRING >= '7' ? 'div>p' : 'tr>td'
     # assert_select cell_selector, text: Regexp.new('Provider'.to_s), count: 2

spec/views/better_together/person_platform_integrations/new.html.erb_spec.rb

@@ -7,7 +7,7 @@
     assign(:person_platform_integration, create(:person_platform_integration))
   end
 
-  it 'renders new person_platform_integration form' do
+  it 'renders new person_platform_integration form' do # rubocop:todo RSpec/NoExpectationExample
     # render
 
     # assert_select 'form[action=?][method=?]', person_platform_integrations_path, 'post' do

spec/views/better_together/person_platform_integrations/show.html.erb_spec.rb

@@ -7,7 +7,7 @@
     assign(:person_platform_integration, create(:person_platform_integration))
   end
 
-  it 'renders attributes in <p>' do
+  it 'renders attributes in <p>' do # rubocop:todo RSpec/NoExpectationExample
     # render
     # expect(rendered).to match(/Provider/)
     # expect(rendered).to match(/Uid/)

spec/views/better_together/seeds/edit.html.erb_spec.rb

@@ -11,7 +11,7 @@
     assign(:seed, seed)
   end
 
-  it 'renders the edit seed form' do
+  it 'renders the edit seed form' do # rubocop:todo RSpec/NoExpectationExample
     # render
 
     # assert_select "form[action=?][method=?]", seed_path(seed), "post" do