feat(models): specify translation types for name and update building connection labels

Author: rsmithlal

app/models/better_together/community.rb

@@ -24,7 +24,7 @@ class Community < ApplicationRecord
     joinable joinable_type: 'community',
              member_type: 'person'
 
-    translates :name
+    translates :name, type: :string
     translates :description, type: :text
     translates :description_html, backend: :action_text
 

app/models/concerns/better_together/infrastructure/building_connections.rb

@@ -35,23 +35,22 @@ def leaflet_points # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
           point = building.to_leaflet_point
           next if point.nil?
 
+          place_label = (" - #{building.address.text_label}" if building.address.text_label.present?)
+
+          place_url = Rails.application.routes.url_helpers.polymorphic_path(
+            self,
+            locale: I18n.locale
+          )
+
+          place_link = "<a href='#{place_url}' class='text-decoration-none'><strong>#{name}#{place_label}</strong></a>"
+
+          address_label = building.address.to_formatted_s(
+            excluded: [:display_label]
+          )
+
           point.merge(
-            label: "<a href='#{Rails.application.routes.url_helpers.polymorphic_path(
-              self,
-              locale: I18n.locale
-            )}' class='text-decoration-none'><strong>#{name}#{if building.address.text_label.present?
-                                                                building.address.text_label
-                                                              end}</strong></a>",
-            popup_html: "<a href='#{Rails.application.routes.url_helpers.polymorphic_path(
-              self,
-              locale: I18n.locale
-            )}' class='text-decoration-none'><strong>#{name}#{if building.address.text_label.present?
-                                                                " - #{building.address.text_label}"
-                                                              end}</strong></a><br>#{
-                                                                building.address.to_formatted_s(
-                                                                  excluded: [:display_label]
-                                                                )
-                                                              }"
+            label: place_link,
+            popup_html: place_link + "<br>#{address_label}"
           )
         end.compact
       end