No longer excluding db schema and migrations from string literal rubocop enforcement

Author: rsmithlal

.rubocop.yml

@@ -2,9 +2,9 @@ AllCops:
   Exclude:
     - 'bin/*'
     - 'node_modules/**/*'
-    - 'spec/dummy/db/schema.rb'
+    # - 'spec/dummy/db/schema.rb'
     - 'vendor/**/*'
   NewCops: enable
-Style/StringLiterals:
-  Exclude:
-    - 'db/migrate/*'
+# Style/StringLiterals:
+#   Exclude:
+#     - 'db/migrate/*'

db/migrate/20190301040948_create_better_together_invitations.rb

@@ -4,7 +4,7 @@
 class CreateBetterTogetherInvitations < ActiveRecord::Migration[7.0]
   def change # rubocop:todo Metrics/MethodLength, Metrics/AbcSize
     create_bt_table :invitations do |t| # rubocop:todo Metrics/BlockLength
-      t.string "type", default: "BetterTogether::Invitation", null: false
+      t.string 'type', default: 'BetterTogether::Invitation', null: false
       t.string :status,
                limit: 20,
                null: false,
@@ -65,11 +65,11 @@ def change # rubocop:todo Metrics/MethodLength, Metrics/AbcSize
 
     add_index :better_together_invitations, %i[invitee_email invitable_id], unique: true,
                                                                             # rubocop:todo Layout/LineLength
-                                                                            name: "invitations_on_invitee_email_and_invitable_id"
+                                                                            name: 'invitations_on_invitee_email_and_invitable_id'
     # rubocop:enable Layout/LineLength
     add_index :better_together_invitations, %i[invitable_id status],
-              name: "invitations_on_invitable_id_and_status"
+              name: 'invitations_on_invitable_id_and_status'
     add_index :better_together_invitations, :invitee_email, where: "status = 'pending'",
-                                                            name: "pending_invites_on_invitee_email"
+                                                            name: 'pending_invites_on_invitee_email'
   end
 end

db/migrate/20190425130144_create_better_together_posts.rb

@@ -4,7 +4,7 @@
 class CreateBetterTogetherPosts < ActiveRecord::Migration[7.0]
   def change # rubocop:todo Metrics/MethodLength
     create_bt_table :posts do |t|
-      t.string "type", default: "BetterTogether::Post", null: false
+      t.string 'type', default: 'BetterTogether::Post', null: false
       t.bt_identifier
       t.bt_protected
       t.bt_privacy

db/migrate/20240522200922_add_primary_community_to_people.rb

@@ -6,7 +6,7 @@ def change
       unless column_exists?(:better_together_people, :community_id, :uuid)
         # Custom community reference here to allow for null references for existing records
         t.bt_references :community, target_table: :better_together_communities, null: true,
-                                    index: { name: "by_person_community" }
+                                    index: { name: 'by_person_community' }
       end
     end
   end

db/migrate/20240826143510_create_better_together_platform_invitations.rb

@@ -74,8 +74,8 @@ def change # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
 
     add_index :better_together_platform_invitations, %i[invitee_email invitable_id], unique: true
     add_index :better_together_platform_invitations, %i[invitable_id status],
-              name: "index_platform_invitations_on_invitable_id_and_status"
+              name: 'index_platform_invitations_on_invitable_id_and_status'
     add_index :better_together_platform_invitations, :invitee_email, where: "status = 'pending'",
-                                                                     name: "index_pending_invitations_on_invitee_email"
+                                                                     name: 'index_pending_invitations_on_invitee_email'
   end
 end

db/migrate/20250227163308_create_better_together_metrics_page_view_reports.rb

@@ -6,7 +6,7 @@ def change
     create_bt_table :page_view_reports, prefix: :better_together_metrics do |t|
       t.jsonb   :filters,             null: false, default: {}
       t.boolean :sort_by_total_views, null: false, default: false
-      t.string  :file_format,         null: false, default: "csv"
+      t.string  :file_format,         null: false, default: 'csv'
       t.jsonb   :report_data,         null: false, default: {}
     end
 

db/migrate/20250228154526_create_better_together_metrics_link_click_reports.rb

@@ -6,7 +6,7 @@ def change
     create_bt_table :link_click_reports, prefix: :better_together_metrics do |t|
       t.jsonb   :filters,                null: false, default: {}
       t.boolean :sort_by_total_clicks,   null: false, default: false
-      t.string  :file_format,            null: false, default: "csv"
+      t.string  :file_format,            null: false, default: 'csv'
       t.jsonb   :report_data,            null: false, default: {}
     end
 

db/migrate/20250304142407_set_privacy_default_private.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
-# Ensures that all tables with the privacy column default to private and replaces existing 'unlisted' values with 'private'
+# Ensures that all tables with the privacy column default to private
+# Replaces existing 'unlisted' values with 'private'
 class SetPrivacyDefaultPrivate < ActiveRecord::Migration[7.1]
   def up
     ActiveRecord::Base.connection.tables.each do |table|