Skip to content

Commit 80e07c4

Browse files
rsmithlalrsmithlal
committed
WIP: feat(translations): enhance translation overview with detailed coverage and performance optimizations
1 parent 45b142b commit 80e07c4

13 files changed

+679
-43
lines changed

‎app/controllers/better_together/translations_controller.rb‎

Lines changed: 239 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,26 +3,34 @@
33
module BetterTogether
44
class TranslationsController < ApplicationController # rubocop:todo Style/Documentation
55
def index
6-
# For overview tab - prepare statistics data
7-
@available_locales = I18n.available_locales.map(&:to_s)
8-
@available_model_types = collect_all_model_types
9-
@available_attributes = collect_all_attributes
6+
# Load only essential data for initial page load with caching
7+
@statistics_cache = build_comprehensive_statistics_cache
108

9+
# Extract essential data from cache for immediate display
10+
@available_locales = I18n.available_locales.map(&:to_s)
1111
@data_type_summary = build_data_type_summary
12-
@data_type_stats = calculate_data_type_stats
1312

14-
# Calculate overview statistics
15-
@locale_stats = calculate_locale_stats
16-
@model_type_stats = calculate_model_type_stats
17-
@attribute_stats = calculate_attribute_stats
18-
@total_translation_records = calculate_total_records
19-
@unique_translated_records = calculate_unique_translated_records
13+
# Basic statistics for lightweight overview
14+
@total_translation_records = @statistics_cache[:total_records]
15+
@unique_translated_records = @statistics_cache[:unique_records]
16+
@locale_stats = @statistics_cache[:locale_stats]
17+
end
18+
19+
def detailed_coverage
20+
# Load comprehensive statistics for detailed view
21+
@statistics_cache = build_comprehensive_statistics_cache
2022

21-
# Calculate model instance translation coverage
22-
@model_instance_stats = calculate_model_instance_stats
23+
@available_model_types = collect_all_model_types
24+
@available_attributes = collect_all_attributes
25+
@data_type_stats = @statistics_cache[:data_type_stats]
26+
@model_type_stats = @statistics_cache[:model_type_stats]
27+
@attribute_stats = @statistics_cache[:attribute_stats]
28+
@model_instance_stats = @statistics_cache[:model_instance_stats]
29+
@locale_gap_summary = @statistics_cache[:locale_gap_summary]
2330

24-
# Calculate locale gap summary for enhanced view
25-
@locale_gap_summary = calculate_locale_gap_summary
31+
respond_to do |format|
32+
format.html { render partial: 'detailed_coverage' }
33+
end
2634
end
2735

2836
def by_locale
@@ -93,6 +101,44 @@ def by_attribute
93101

94102
private
95103

104+
def build_comprehensive_statistics_cache
105+
Rails.cache.fetch("translations_statistics_#{cache_key_suffix}", expires_in: 1.hour) do
106+
{
107+
total_records: calculate_total_records,
108+
unique_records: calculate_unique_translated_records,
109+
locale_stats: calculate_locale_stats,
110+
model_type_stats: calculate_model_type_stats_optimized,
111+
attribute_stats: calculate_attribute_stats_optimized,
112+
data_type_stats: calculate_data_type_stats,
113+
model_instance_stats: calculate_model_instance_stats_optimized,
114+
locale_gap_summary: calculate_locale_gap_summary_optimized
115+
}
116+
end
117+
end
118+
119+
def cache_key_suffix
120+
# Include factors that would invalidate the cache
121+
cache_components = []
122+
123+
if defined?(Mobility::Backends::ActiveRecord::KeyValue::StringTranslation)
124+
cache_components << Mobility::Backends::ActiveRecord::KeyValue::StringTranslation.maximum(:updated_at)
125+
end
126+
127+
if defined?(Mobility::Backends::ActiveRecord::KeyValue::TextTranslation)
128+
cache_components << Mobility::Backends::ActiveRecord::KeyValue::TextTranslation.maximum(:updated_at)
129+
end
130+
131+
cache_components << ActionText::RichText.maximum(:updated_at) if defined?(ActionText::RichText)
132+
133+
cache_components << I18n.available_locales.join('-')
134+
cache_components.compact.join('-')
135+
end
136+
137+
def invalidate_translation_caches
138+
Rails.cache.delete_matched('translations_statistics_*')
139+
Rails.cache.delete_matched('translation_coverage_*')
140+
end
141+
96142
def collect_all_model_types
97143
model_types = Set.new
98144

@@ -715,6 +761,184 @@ def calculate_unique_translated_records
715761
unique_records.size
716762
end
717763

764+
# Optimized versions for bulk operations
765+
def calculate_model_type_stats_optimized
766+
stats = {}
767+
768+
# Single optimized query per translation type
769+
fetch_all_translation_data_bulk.each do |model_type, translation_counts|
770+
stats[model_type] = translation_counts[:total_count] || 0
771+
end
772+
773+
stats.sort_by { |_, count| -count }.to_h
774+
end
775+
776+
def calculate_attribute_stats_optimized
777+
stats = {}
778+
779+
fetch_all_translation_data_bulk.each do |_, translation_counts|
780+
translation_counts[:by_attribute]&.each do |attribute, count|
781+
stats[attribute] = (stats[attribute] || 0) + count
782+
end
783+
end
784+
785+
stats.sort_by { |_, count| -count }.to_h
786+
end
787+
788+
def fetch_all_translation_data_bulk
789+
@_bulk_translation_data ||= Rails.cache.fetch("bulk_translation_data_#{cache_key_suffix}",
790+
expires_in: 30.minutes) do
791+
data = {}
792+
793+
# Bulk query string translations
794+
if defined?(Mobility::Backends::ActiveRecord::KeyValue::StringTranslation)
795+
Mobility::Backends::ActiveRecord::KeyValue::StringTranslation
796+
.group(:translatable_type, :key)
797+
.count
798+
.each do |(type, key), count|
799+
data[type] ||= { total_count: 0, by_attribute: {}, unique_instances: Set.new }
800+
data[type][:total_count] += count
801+
data[type][:by_attribute][key] = (data[type][:by_attribute][key] || 0) + count
802+
end
803+
end
804+
805+
# Bulk query text translations
806+
if defined?(Mobility::Backends::ActiveRecord::KeyValue::TextTranslation)
807+
Mobility::Backends::ActiveRecord::KeyValue::TextTranslation
808+
.group(:translatable_type, :key)
809+
.count
810+
.each do |(type, key), count|
811+
data[type] ||= { total_count: 0, by_attribute: {}, unique_instances: Set.new }
812+
data[type][:total_count] += count
813+
data[type][:by_attribute][key] = (data[type][:by_attribute][key] || 0) + count
814+
end
815+
end
816+
817+
# Bulk query rich text translations
818+
if defined?(ActionText::RichText)
819+
ActionText::RichText
820+
.group(:record_type, :name)
821+
.count
822+
.each do |(type, name), count|
823+
data[type] ||= { total_count: 0, by_attribute: {}, unique_instances: Set.new }
824+
data[type][:total_count] += count
825+
data[type][:by_attribute][name] = (data[type][:by_attribute][name] || 0) + count
826+
end
827+
end
828+
829+
# Convert unique_instances sets to counts
830+
data.each do |_type, type_data|
831+
type_data[:unique_instances] = type_data[:unique_instances].size
832+
end
833+
834+
data
835+
end
836+
end
837+
838+
def calculate_model_instance_stats_optimized
839+
stats = {}
840+
841+
# Get bulk data and model counts efficiently
842+
translation_data = fetch_all_translation_data_bulk
843+
model_counts = fetch_all_model_counts_bulk
844+
845+
translation_data.each do |model_name, translation_counts|
846+
total_instances = model_counts[model_name] || 0
847+
translated_instances = calculate_translated_instances_for_model(model_name)
848+
849+
stats[model_name] = {
850+
total_instances: total_instances,
851+
translated_instances: translated_instances,
852+
translation_coverage: calculate_coverage_percentage(translated_instances, total_instances),
853+
attribute_coverage: translation_counts[:by_attribute] || {}
854+
}
855+
end
856+
857+
stats
858+
end
859+
860+
def fetch_all_model_counts_bulk
861+
@_bulk_model_counts ||= Rails.cache.fetch("bulk_model_counts_#{cache_key_suffix}", expires_in: 30.minutes) do
862+
counts = {}
863+
864+
collect_all_model_types.each do |model_name|
865+
model_class = model_name.constantize
866+
counts[model_name] = model_class.count
867+
rescue StandardError => e
868+
Rails.logger.warn("Could not count instances for #{model_name}: #{e.message}")
869+
counts[model_name] = 0
870+
end
871+
872+
counts
873+
end
874+
end
875+
876+
def calculate_translated_instances_for_model(model_name)
877+
unique_instances = Set.new
878+
879+
# Collect unique translated instance IDs from all translation types
880+
if defined?(Mobility::Backends::ActiveRecord::KeyValue::StringTranslation)
881+
Mobility::Backends::ActiveRecord::KeyValue::StringTranslation
882+
.where(translatable_type: model_name)
883+
.distinct
884+
.pluck(:translatable_id)
885+
.each { |id| unique_instances.add(id) }
886+
end
887+
888+
if defined?(Mobility::Backends::ActiveRecord::KeyValue::TextTranslation)
889+
Mobility::Backends::ActiveRecord::KeyValue::TextTranslation
890+
.where(translatable_type: model_name)
891+
.distinct
892+
.pluck(:translatable_id)
893+
.each { |id| unique_instances.add(id) }
894+
end
895+
896+
if defined?(ActionText::RichText)
897+
ActionText::RichText
898+
.where(record_type: model_name)
899+
.distinct
900+
.pluck(:record_id)
901+
.each { |id| unique_instances.add(id) }
902+
end
903+
904+
unique_instances.size
905+
end
906+
907+
def calculate_coverage_percentage(translated, total)
908+
return 0.0 if total.zero?
909+
910+
((translated.to_f / total) * 100).round(2)
911+
end
912+
913+
def calculate_locale_gap_summary_optimized
914+
Rails.cache.fetch("locale_gap_summary_#{cache_key_suffix}", expires_in: 30.minutes) do
915+
# Simplified gap summary focusing on key metrics
916+
{
917+
missing_translations_by_locale: calculate_missing_translations_by_locale_bulk,
918+
coverage_percentage_by_locale: calculate_coverage_by_locale_bulk
919+
}
920+
end
921+
end
922+
923+
def calculate_missing_translations_by_locale_bulk
924+
gaps = {}
925+
I18n.available_locales.each do |locale|
926+
gaps[locale.to_s] = 0
927+
end
928+
929+
# Simplified calculation for demonstration
930+
# In production, you'd implement more efficient bulk queries here
931+
gaps
932+
end
933+
934+
def calculate_coverage_by_locale_bulk
935+
coverage = {}
936+
I18n.available_locales.each do |locale|
937+
coverage[locale.to_s] = rand(70..98).round(2) # Placeholder - replace with actual calculation
938+
end
939+
coverage
940+
end
941+
718942
# Calculate unique model instance translation coverage
719943
def calculate_model_instance_stats
720944
stats = {}

‎app/views/better_together/translations/_detailed_coverage.html.erb‎

Lines changed: 95 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,95 @@
1+
<%= turbo_frame_tag :detailed_coverage do %>
2+
<div class="card">
3+
<div class="card-header">
4+
<h5 class="card-title mb-0">
5+
<i class="fa-solid fa-chart-bar me-2" aria-hidden="true"></i>
6+
<%= t('.detailed_coverage') %>
7+
</h5>
8+
</div>
9+
<div class="card-body">
10+
<!-- Model Type Coverage -->
11+
<% if @model_type_stats&.any? %>
12+
<div class="mb-4">
13+
<h6 class="border-bottom pb-2 mb-3">
14+
<i class="fa-solid fa-cube me-2" aria-hidden="true"></i>
15+
<%= t('.model_coverage') %>
16+
</h6>
17+
<div class="row">
18+
<% @model_type_stats.first(6).each do |model_type, count| %>
19+
<div class="col-md-4 mb-2">
20+
<div class="progress" style="height: 25px;">
21+
<% percentage = (@model_instance_stats&.dig(model_type, :translation_coverage) || 0) %>
22+
<div class="progress-bar"
23+
role="progressbar"
24+
style="width: <%= percentage %>%;"
25+
aria-valuenow="<%= percentage %>"
26+
aria-valuemin="0"
27+
aria-valuemax="100">
28+
<small><%= model_type.demodulize %> (<%= percentage.round(1) %>%)</small>
29+
</div>
30+
</div>
31+
</div>
32+
<% end %>
33+
</div>
34+
</div>
35+
<% end %>
36+
37+
<!-- Data Type Summary -->
38+
<% if @data_type_stats&.any? %>
39+
<div class="mb-4">
40+
<h6 class="border-bottom pb-2 mb-3">
41+
<i class="fa-solid fa-database me-2" aria-hidden="true"></i>
42+
<%= t('.data_type_summary') %>
43+
</h6>
44+
<div class="row">
45+
<% @data_type_stats.each do |data_type, stats| %>
46+
<div class="col-md-6 mb-3">
47+
<div class="card bg-light">
48+
<div class="card-body py-2">
49+
<h6 class="card-title mb-1">
50+
<%= data_type.to_s.humanize %>
51+
<span class="badge bg-primary"><%= number_with_delimiter(stats[:count] || 0) %></span>
52+
</h6>
53+
<small class="text-muted">
54+
<%= stats[:models]&.size || 0 %> <%= t('.models_affected') %>
55+
</small>
56+
</div>
57+
</div>
58+
</div>
59+
<% end %>
60+
</div>
61+
</div>
62+
<% end %>
63+
64+
<!-- Top Attributes -->
65+
<% if @attribute_stats&.any? %>
66+
<div>
67+
<h6 class="border-bottom pb-2 mb-3">
68+
<i class="fa-solid fa-tag me-2" aria-hidden="true"></i>
69+
<%= t('.top_attributes') %>
70+
</h6>
71+
<div class="row">
72+
<% @attribute_stats.first(8).each do |attribute, count| %>
73+
<div class="col-md-3 mb-2">
74+
<div class="card">
75+
<div class="card-body text-center py-2">
76+
<small class="text-muted"><%= attribute %></small><br>
77+
<strong><%= number_with_delimiter(count) %></strong>
78+
</div>
79+
</div>
80+
</div>
81+
<% end %>
82+
</div>
83+
</div>
84+
<% end %>
85+
86+
<!-- Load Time Info -->
87+
<div class="mt-3 text-center">
88+
<small class="text-muted">
89+
<i class="fa-solid fa-clock me-1" aria-hidden="true"></i>
90+
<%= t('.loaded_at', time: Time.current.strftime("%H:%M:%S")) %>
91+
</small>
92+
</div>
93+
</div>
94+
</div>
95+
<% end %>

‎app/views/better_together/translations/_loading_placeholder.html.erb‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
<div class="text-center py-5">
2+
<div class="spinner-border text-primary" role="status">
3+
<span class="visually-hidden"><%= t('.loading') %></span>
4+
</div>
5+
<p class="mt-3 text-muted"><%= message %></p>
6+
</div>

0 commit comments

Comments
 (0)