Enhance permitted attributes for navigation areas and items, ensuring persistence of core fields in controller specs

Author: rsmithlal

app/models/better_together/navigation_area.rb

@@ -47,5 +47,16 @@ def top_level_nav_items_includes_children
     def to_s
       name
     end
+
+    def self.permitted_attributes(id: false, destroy: false)
+      # Allow core fields for creating/updating navigation areas
+      attrs = %i[
+        name
+        style
+        visible
+      ]
+
+      super + attrs
+    end
   end
 end

spec/requests/better_together/navigation_areas_controller_spec.rb

@@ -20,7 +20,7 @@
 
     describe 'POST /:locale/.../navigation_areas' do
       # rubocop:todo RSpec/MultipleExpectations
-      it 'creates and redirects on valid params' do # rubocop:todo RSpec/ExampleLength, RSpec/MultipleExpectations
+      it 'creates and redirects on valid params, persisting permitted fields' do # rubocop:todo RSpec/ExampleLength, RSpec/MultipleExpectations
         # rubocop:enable RSpec/MultipleExpectations
         post better_together.navigation_areas_path(locale:), params: {
           navigation_area: {
@@ -33,6 +33,11 @@
         expect(response).to have_http_status(:found)
         follow_redirect!
         expect(response).to have_http_status(:ok)
+
+        area = BetterTogether::NavigationArea.find_by(identifier: 'main-nav')
+        expect(area).to be_present
+        expect(area.style).to eq('primary')
+        expect(area.visible).to eq(true)
       end
 
       it 'renders new on invalid params (HTML 200)' do
@@ -45,14 +50,17 @@
       let!(:area) { create(:better_together_navigation_area, protected: false) }
 
       # rubocop:todo RSpec/MultipleExpectations
-      it 'updates and redirects on valid params' do # rubocop:todo RSpec/ExampleLength, RSpec/MultipleExpectations
+      it 'updates and redirects on valid params, applying changes' do # rubocop:todo RSpec/ExampleLength, RSpec/MultipleExpectations
         # rubocop:enable RSpec/MultipleExpectations
         patch better_together.navigation_area_path(locale:, id: area.slug), params: {
-          navigation_area: { style: 'secondary' }
+          navigation_area: { style: 'secondary', visible: false }
         }
         expect(response).to have_http_status(:found)
         follow_redirect!
         expect(response).to have_http_status(:ok)
+
+        expect(area.reload.style).to eq('secondary')
+        expect(area.reload.visible).to eq(false)
       end
 
       it 'renders edit on invalid params (HTML 200)' do

spec/requests/better_together/navigation_items_controller_spec.rb

@@ -30,7 +30,7 @@
     end
 
     # rubocop:todo RSpec/MultipleExpectations
-    it 'creates a navigation item and redirects (HTML)' do # rubocop:todo RSpec/ExampleLength, RSpec/MultipleExpectations
+    it 'creates a navigation item and redirects (HTML), persisting permitted fields' do # rubocop:todo RSpec/ExampleLength, RSpec/MultipleExpectations
       # rubocop:enable RSpec/MultipleExpectations
       post better_together.navigation_area_navigation_items_path(
         locale:,
@@ -40,6 +40,15 @@
       expect(response).to have_http_status(:found)
       follow_redirect!
       expect(response).to have_http_status(:ok)
+
+      # Verify attributes were persisted via strong params
+      created = BetterTogether::NavigationItem.order(:created_at).last
+      expect(created).to be_present
+      expect(created.navigation_area_id).to eq(navigation_area.id)
+      expect(created.title(locale:)).to eq(params[:navigation_item]["title_#{locale}"])
+      expect(created.url).to eq(params[:navigation_item][:url])
+      expect(created.visible).to eq(params[:navigation_item][:visible])
+      expect(created.item_type).to eq(params[:navigation_item][:item_type])
     end
 
     it 'renders errors on invalid params' do
@@ -62,7 +71,7 @@
     end
 
     # rubocop:todo RSpec/MultipleExpectations
-    it 'updates with valid params then redirects' do # rubocop:todo RSpec/ExampleLength, RSpec/MultipleExpectations
+    it 'updates with valid params then redirects and applies changes' do # rubocop:todo RSpec/ExampleLength, RSpec/MultipleExpectations
       # rubocop:enable RSpec/MultipleExpectations
       put better_together.navigation_area_navigation_item_path(
         locale:,
@@ -73,6 +82,8 @@
       expect(response).to have_http_status(:found)
       follow_redirect!
       expect(response).to have_http_status(:ok)
+
+      expect(item.reload.title(locale:)).to eq('Updated Title')
     end
 
     it 'renders edit on invalid params (422)' do # rubocop:todo RSpec/ExampleLength