Skip to content

Commit afaf155

Browse files
authored
Build(deps-dev): Bump rubocop from 1.76.2 to 1.78.0 (#885)
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.76.2 to 1.78.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rubocop/rubocop/releases">rubocop's releases</a>.</em></p> <blockquote> <h2>RuboCop v1.78.0</h2> <h3>New features</h3> <ul> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14331">#14331</a>: Enhance <code>Naming/MethodName</code> cop to detect offenses within <code>define_method</code> calls. (<a href="https://github.com/viralpraxis"><code>@​viralpraxis</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14325">#14325</a>: Enhance <code>Naming/MethodName</code> cop to handle offenses within <code>Struct</code> members. (<a href="https://github.com/viralpraxis"><code>@​viralpraxis</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14335">#14335</a>: Enhance <code>Security/Eval</code> cop to detect <code>Kernel.eval</code> calls. (<a href="https://github.com/viralpraxis"><code>@​viralpraxis</code></a>)</li> </ul> <h3>Bug fixes</h3> <ul> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14343">#14343</a>: Fix autocorrect code for <code>Style/HashConversion</code> to avoid syntax error. (<a href="https://github.com/koic"><code>@​koic</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14346">#14346</a>: Avoid requiring parentheses for <code>Style/SingleLineMethods</code>. (<a href="https://github.com/koic"><code>@​koic</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14339">#14339</a>: Fix bug where specifying <code>--format</code> disables parallelization. (<a href="https://github.com/r7kamura"><code>@​r7kamura</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14300">#14300</a>: Fix false positives for <code>Lint/DuplicateMethods</code> cop when self-alias trick is used. (<a href="https://github.com/viralpraxis"><code>@​viralpraxis</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14329">#14329</a>: Fix false positives for <code>Lint/LiteralAsCondition</code> when a literal is used inside <code>||</code> in <code>case</code> condition. (<a href="https://github.com/koic"><code>@​koic</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14326">#14326</a>: Fix additional autocorrection errors in <code>Style/HashConversion</code> for nested <code>Hash[]</code> calls. (<a href="https://github.com/dvandersluis"><code>@​dvandersluis</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14031">#14031</a>: Honor --config options on server mode. (<a href="https://github.com/steiley"><code>@​steiley</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14319">#14319</a>: Fix the following incorrect autocorrect for <code>Lint/RedundantTypeConversion</code> when using parentheses with no arguments or any arguments. (<a href="https://github.com/koic"><code>@​koic</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14336">#14336</a>: Fix incorrect autocorrect for <code>Style/ItBlockParameter</code> when using a single numbered parameter after multiple numbered parameters in a method chain. (<a href="https://github.com/koic"><code>@​koic</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/11782">#11782</a>: Move pending cops warning out of ConfigLoader. (<a href="https://github.com/nobuyo"><code>@​nobuyo</code></a>)</li> </ul> <h3>Changes</h3> <ul> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14318">#14318</a>: Add <code>WaywardPredicates</code> config to <code>Naming/PredicateMethod</code> to handle methods that look like predicates but aren't. (<a href="https://github.com/dvandersluis"><code>@​dvandersluis</code></a>)</li> </ul> <h2>RuboCop v1.77.0</h2> <h3>New features</h3> <ul> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14223">#14223</a>: Add new <code>Gemspec/AttributeAssignment</code> cop. (<a href="https://github.com/viralpraxis"><code>@​viralpraxis</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14128">#14128</a>: Allow long fully-qualified namespace strings to exceed max length. ([<a href="https://github.com/niranjan-patil"><code>@​niranjan-patil</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14288">#14288</a>: Add new cop <code>Style/CollectionQuerying</code>. ([<a href="https://github.com/lovro-bikic"><code>@​lovro-bikic</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14165">#14165</a>: Add new <code>DefaultToNil</code> option to <code>Style/FetchEnvVar</code> cop. ([<a href="https://github.com/Yuhi-Sato"><code>@​Yuhi-Sato</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14314">#14314</a>: Enhance <code>Gemspec/RequireMFA</code> cop autocorrect to insert MFA directive after last <code>metadata</code> assignment. (<a href="https://github.com/viralpraxis"><code>@​viralpraxis</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14159">#14159</a>: Enhance <code>Layout/SpaceInsideArrayLiteralBrackets</code> cop to analyze nested constant patterns. (<a href="https://github.com/viralpraxis"><code>@​viralpraxis</code></a>)</li> </ul> <h3>Bug fixes</h3> <ul> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14306">#14306</a>: Fix an error for <code>Style/HashConversion</code> when using nested <code>Hash[]</code>. (<a href="https://github.com/koic"><code>@​koic</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14298">#14298</a>: Fix an error for <code>Style/SoleNestedConditional</code> when autocorrecting nested if/unless/if. ([<a href="https://github.com/ssagara00"><code>@​ssagara00</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14313">#14313</a>: Fix a false positive for <code>Layout/SpaceBeforeBrackets</code> when call desugared <code>Hash#[]</code> to lvar receiver with a space around the dot. (<a href="https://github.com/koic"><code>@​koic</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14292">#14292</a>: Fix false positives for <code>Style/RedundantParentheses</code> when assigning a parenthesized one-line <code>in</code> pattern matching. (<a href="https://github.com/koic"><code>@​koic</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14296">#14296</a>: Fix false positives for <code>Style/RedundantSelf</code> when receiver and lvalue have the same name in or-assignment. (<a href="https://github.com/koic"><code>@​koic</code></a>)</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14303">#14303</a>: Fix <code>Lint/SelfAssignment</code> to allow inline RBS comments. ([<a href="https://github.com/Morriar"><code>@​Morriar</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14307">#14307</a>: Fix <code>Style/MethodCallWithArgsParentheses</code> false positive on forwarded keyword argument with additional arguments. (<a href="https://github.com/viralpraxis"><code>@​viralpraxis</code></a>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md">rubocop's changelog</a>.</em></p> <blockquote> <h2>1.78.0 (2025-07-08)</h2> <h3>New features</h3> <ul> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14331">#14331</a>: Enhance <code>Naming/MethodName</code> cop to detect offenses within <code>define_method</code> calls. ([<a href="https://github.com/viralpraxis"><code>@​viralpraxis</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14325">#14325</a>: Enhance <code>Naming/MethodName</code> cop to handle offenses within <code>Struct</code> members. ([<a href="https://github.com/viralpraxis"><code>@​viralpraxis</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14335">#14335</a>: Enhance <code>Security/Eval</code> cop to detect <code>Kernel.eval</code> calls. ([<a href="https://github.com/viralpraxis"><code>@​viralpraxis</code></a>][])</li> </ul> <h3>Bug fixes</h3> <ul> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14343">#14343</a>: Fix autocorrect code for <code>Style/HashConversion</code> to avoid syntax error. ([<a href="https://github.com/koic"><code>@​koic</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14346">#14346</a>: Avoid requiring parentheses for <code>Style/SingleLineMethods</code>. ([<a href="https://github.com/koic"><code>@​koic</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14339">#14339</a>: Fix bug where specifying <code>--format</code> disables parallelization. ([<a href="https://github.com/r7kamura"><code>@​r7kamura</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14300">#14300</a>: Fix false positives for <code>Lint/DuplicateMethods</code> cop when self-alias trick is used. ([<a href="https://github.com/viralpraxis"><code>@​viralpraxis</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14329">#14329</a>: Fix false positives for <code>Lint/LiteralAsCondition</code> when a literal is used inside <code>||</code> in <code>case</code> condition. ([<a href="https://github.com/koic"><code>@​koic</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14326">#14326</a>: Fix additional autocorrection errors in <code>Style/HashConversion</code> for nested <code>Hash[]</code> calls. ([<a href="https://github.com/dvandersluis"><code>@​dvandersluis</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14031">#14031</a>: Honor --config options on server mode. ([<a href="https://github.com/steiley"><code>@​steiley</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14319">#14319</a>: Fix the following incorrect autocorrect for <code>Lint/RedundantTypeConversion</code> when using parentheses with no arguments or any arguments. ([<a href="https://github.com/koic"><code>@​koic</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14336">#14336</a>: Fix incorrect autocorrect for <code>Style/ItBlockParameter</code> when using a single numbered parameter after multiple numbered parameters in a method chain. ([<a href="https://github.com/koic"><code>@​koic</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/11782">#11782</a>: Move pending cops warning out of ConfigLoader. ([<a href="https://github.com/nobuyo"><code>@​nobuyo</code></a>][])</li> </ul> <h3>Changes</h3> <ul> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14318">#14318</a>: Add <code>WaywardPredicates</code> config to <code>Naming/PredicateMethod</code> to handle methods that look like predicates but aren't. ([<a href="https://github.com/dvandersluis"><code>@​dvandersluis</code></a>][])</li> </ul> <h2>1.77.0 (2025-06-20)</h2> <h3>New features</h3> <ul> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14223">#14223</a>: Add new <code>Gemspec/AttributeAssignment</code> cop. ([<a href="https://github.com/viralpraxis"><code>@​viralpraxis</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14128">#14128</a>: Allow long fully-qualified namespace strings to exceed max length. ([<a href="https://github.com/niranjan-patil"><code>@​niranjan-patil</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14288">#14288</a>: Add new cop <code>Style/CollectionQuerying</code>. ([<a href="https://github.com/lovro-bikic"><code>@​lovro-bikic</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14165">#14165</a>: Add new <code>DefaultToNil</code> option to <code>Style/FetchEnvVar</code> cop. ([<a href="https://github.com/Yuhi-Sato"><code>@​Yuhi-Sato</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14314">#14314</a>: Enhance <code>Gemspec/RequireMFA</code> cop autocorrect to insert MFA directive after last <code>metadata</code> assignment. ([<a href="https://github.com/viralpraxis"><code>@​viralpraxis</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14159">#14159</a>: Enhance <code>Layout/SpaceInsideArrayLiteralBrackets</code> cop to analyze nested constant patterns. ([<a href="https://github.com/viralpraxis"><code>@​viralpraxis</code></a>][])</li> </ul> <h3>Bug fixes</h3> <ul> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14306">#14306</a>: Fix an error for <code>Style/HashConversion</code> when using nested <code>Hash[]</code>. ([<a href="https://github.com/koic"><code>@​koic</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14298">#14298</a>: Fix an error for <code>Style/SoleNestedConditional</code> when autocorrecting nested if/unless/if. ([<a href="https://github.com/ssagara00"><code>@​ssagara00</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14313">#14313</a>: Fix a false positive for <code>Layout/SpaceBeforeBrackets</code> when call desugared <code>Hash#[]</code> to lvar receiver with a space around the dot. ([<a href="https://github.com/koic"><code>@​koic</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14292">#14292</a>: Fix false positives for <code>Style/RedundantParentheses</code> when assigning a parenthesized one-line <code>in</code> pattern matching. ([<a href="https://github.com/koic"><code>@​koic</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14296">#14296</a>: Fix false positives for <code>Style/RedundantSelf</code> when receiver and lvalue have the same name in or-assignment. ([<a href="https://github.com/koic"><code>@​koic</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14303">#14303</a>: Fix <code>Lint/SelfAssignment</code> to allow inline RBS comments. ([<a href="https://github.com/Morriar"><code>@​Morriar</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14307">#14307</a>: Fix <code>Style/MethodCallWithArgsParentheses</code> false positive on forwarded keyword argument with additional arguments. ([<a href="https://github.com/viralpraxis"><code>@​viralpraxis</code></a>][])</li> <li><a href="https://redirect.github.com/rubocop/rubocop/issues/14301">#14301</a>: Fix autocorrection syntax error for multiline expressions in <code>Style/RedundantParentheses</code>. ([<a href="https://github.com/lovro-bikic"><code>@​lovro-bikic</code></a>][])</li> </ul> <h3>Changes</h3> <ul> <li><a href="https://redirect.github.com/rubocop/rubocop/pull/14295">#14295</a>: Update <code>Naming/PredicateMethod</code> to consider negation (<code>!</code>/<code>not</code>) as boolean values. ([<a href="https://github.com/dvandersluis"><code>@​dvandersluis</code></a>][])</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rubocop/rubocop/commit/dd441f4af06cc9cbeac0970944fb2c1686888713"><code>dd441f4</code></a> Cut 1.78</li> <li><a href="https://github.com/rubocop/rubocop/commit/0687f0453ecb45a48b766e3c8f7845f0ea11aa5a"><code>0687f04</code></a> Update Changelog</li> <li><a href="https://github.com/rubocop/rubocop/commit/9322c7d808452fa138b3a58a0f0362bd0e2c55be"><code>9322c7d</code></a> Tweak docstring</li> <li><a href="https://github.com/rubocop/rubocop/commit/2508d948bb56367620b9056ae2b31a7c8dc7bd5f"><code>2508d94</code></a> Fix false positives for Lint/DuplicateMethods when the self-alias trick is used</li> <li><a href="https://github.com/rubocop/rubocop/commit/9582c403159e60896ffa83c0f34c917bbba0605d"><code>9582c40</code></a> [Fix <a href="https://redirect.github.com/rubocop/rubocop/issues/11782">#11782</a>] Move pending cops warning out of ConfigLoader</li> <li><a href="https://github.com/rubocop/rubocop/commit/6c863b3b3ad5eae2b923fa62a0016f36b041f223"><code>6c863b3</code></a> [Fix <a href="https://redirect.github.com/rubocop/rubocop/issues/14346">#14346</a>] Avoid requiring parentheses for <code>Style/SingleLineMethods</code></li> <li><a href="https://github.com/rubocop/rubocop/commit/0b08bb87f150aa44894cf1155cf1c229f0935a35"><code>0b08bb8</code></a> Merge pull request <a href="https://redirect.github.com/rubocop/rubocop/issues/14343">#14343</a> from koic/fix_autocorrect_for_style_hash_conversion</li> <li><a href="https://github.com/rubocop/rubocop/commit/0ef54b54944dea0bb85057d529eea0d68d621b52"><code>0ef54b5</code></a> Fix autocorrect for <code>Style/HashConversion</code> to avoid syntax error</li> <li><a href="https://github.com/rubocop/rubocop/commit/01fdcbba4a2593e6537f4ff9435b1a061d885b45"><code>01fdcbb</code></a> Remove redundant method call in <code>def_node_matcher</code></li> <li><a href="https://github.com/rubocop/rubocop/commit/a80d92b0a3885879f4d8530517526bc0269a4f0f"><code>a80d92b</code></a> [Doc] Remove redundant blank line</li> <li>Additional commits viewable in <a href="https://github.com/rubocop/rubocop/compare/v1.76.2...v1.78.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=rubocop&package-manager=bundler&previous-version=1.76.2&new-version=1.78.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
2 parents 8708bf1 + b6faae9 commit afaf155

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

Gemfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -658,7 +658,7 @@ GEM
658658
rswag-ui (2.16.0)
659659
actionpack (>= 5.2, < 8.1)
660660
railties (>= 5.2, < 8.1)
661-
rubocop (1.76.2)
661+
rubocop (1.78.0)
662662
json (~> 2.3)
663663
language_server-protocol (~> 3.17.0.2)
664664
lint_roller (~> 1.1.0)

app/models/better_together/navigation_item.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,7 @@ def self.route_name_urls
8282
pages = BetterTogether::Page.arel_table
8383

8484
# Construct the LEFT OUTER JOIN condition
85-
# rubocop:todo Layout/LineLength
8685
join_condition = navigation_items[:linkable_type].eq('BetterTogether::Page').and(navigation_items[:linkable_id].eq(pages[:id]))
87-
# rubocop:enable Layout/LineLength
8886
join = navigation_items
8987
.join(pages, Arel::Nodes::OuterJoin)
9088
.on(join_condition)

app/models/better_together/page.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,11 @@ class Page < ApplicationRecord
4949
scope :by_publication_date, -> { order(published_at: :desc) }
5050

5151
def hero_block
52-
# rubocop:todo Layout/LineLength
5352
@hero_block ||= blocks.where(type: 'BetterTogether::Content::Hero').with_attached_background_image_file.with_translations.first
54-
# rubocop:enable Layout/LineLength
5553
end
5654

5755
def content_blocks
58-
# rubocop:todo Layout/LineLength
5956
@content_blocks ||= blocks.where.not(type: 'BetterTogether::Content::Hero').with_attached_background_image_file.with_translations
60-
# rubocop:enable Layout/LineLength
6157
end
6258

6359
# Customize the data sent to Elasticsearch for indexing

app/models/concerns/better_together/primary_flag.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@ def extra_permitted_attributes
1919
super + [:primary_flag]
2020
end
2121

22-
def has_primary_for(parent_id) # rubocop:todo Naming/PredicatePrefix
22+
# rubocop:todo Naming/PredicateMethod
23+
def has_primary_for(parent_id) # rubocop:todo Naming/PredicatePrefix, Naming/PredicateMethod
24+
# rubocop:enable Naming/PredicateMethod
2325
return false unless parent_id && primary_flag_scope_key
2426

2527
where(primary_flag: true, primary_flag_scope_key => parent_id).exists?

0 commit comments

Comments
 (0)