Skip to content

Conversation

@rsmithlal
Copy link
Member

  • Implement ChecklistPolicy and ChecklistItemPolicy for authorization.
  • Create views for checklists including index, show, new, edit, and form partials.
  • Add routes for checklists and nested checklist items.
  • Create migrations for checklists and checklist items with necessary fields.
  • Add factories for checklist and checklist items for testing.
  • Implement request specs for checklist CRUD operations and authorization.
  • Update locale files for checklist-related translations.

Summary

Describe the change and the motivation.

Checklist

  • Tests added/updated and passing (bin/ci).
  • Lint and security checks (rubocop, brakeman, bundler-audit).
  • Documentation updated under docs/ describing new/changed functionality.
  • Mermaid diagrams (docs/*.mmd) updated to reflect changes.
  • Rendered PNGs regenerated with bin/render_diagrams and committed.
  • For DB changes, included any needed backfills/dedupes and noted risks.

Screenshots / Diagrams

If applicable, include screenshots or link to updated diagrams.

Notes

Anything reviewers should be aware of (migration order, flags, feature toggles).

- Implement ChecklistPolicy and ChecklistItemPolicy for authorization.
- Create views for checklists including index, show, new, edit, and form partials.
- Add routes for checklists and nested checklist items.
- Create migrations for checklists and checklist items with necessary fields.
- Add factories for checklist and checklist items for testing.
- Implement request specs for checklist CRUD operations and authorization.
- Update locale files for checklist-related translations.
- Add a new Stimulus controller for managing person checklist item states.
- Update the Checklist model to include positioned checklist items.
- Modify the PersonChecklistItem model to remove unnecessary protection.
- Enhance the ChecklistPolicy to include completion status permissions.
- Revamp checklist item view to support person-specific toggling and display.
- Create new partials for checklist item lists and contents for better Turbo integration.
- Add edit view for checklist items.
- Update checklist show view to incorporate new checklist item rendering logic.
- Extend routes to support person checklist item endpoints.
- Implement feature specs for person checklist item completion and reordering.
- Add request specs for JSON responses related to person checklist items.
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

…ions/community-engine-rails into feature/checklists
… improve existing item ID retrieval in specs
@rsmithlal rsmithlal merged commit 79e1717 into main Sep 2, 2025
12 checks passed
@rsmithlal rsmithlal deleted the feature/checklists branch September 2, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants