Fix/requires #1070
Fix/requires #1070
Conversation
This (partially) reverts commit 8cf9077.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| # frozen_string_literal: true | ||
|
|
||
| # require 'simple_calendar/calendar_helper' | ||
|
|
||
| require_dependency 'simple_calendar/calendar_helper' |
There was a problem hiding this comment.
[P1] Reintroduces missing simple_calendar helper file
The helper now calls require_dependency 'simple_calendar/calendar_helper', but the simple_calendar gem does not expose a simple_calendar/calendar_helper.rb file. This explicit require was previously removed (see earlier commit message) because it raises LoadError: cannot load such file -- simple_calendar/calendar_helper when the helper is eager loaded in production. Adding the dependency again will bring that boot-time failure back. Loading the gem via require 'simple_calendar' in the engine is sufficient, so this extra require should be dropped.
Useful? React with 👍 / 👎.
Summary
Describe the change and the motivation.
Checklist
bin/ci).rubocop,brakeman,bundler-audit).docs/describing new/changed functionality.docs/*.mmd) updated to reflect changes.bin/render_diagramsand committed.Screenshots / Diagrams
If applicable, include screenshots or link to updated diagrams.
Notes
Anything reviewers should be aware of (migration order, flags, feature toggles).