-
Notifications
You must be signed in to change notification settings - Fork 5
Feat/password complexity #1133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feat/password complexity #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h validation and update locale messages
Auto-building the person was causing issues with registration race conditions
- Updated password references in various test files to use a more secure password 'SecureTest123!@#' instead of 'password12345'. - Removed redundant default parameters in translation calls in offer list item views. - Added missing translation key for 'password' in locale files. - Ensured consistent password usage across all user creation and login scenarios in specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces password strength validation using the
devise_zxcvbngem and improves internationalization for password-related messages. The most significant changes include adding the new dependency, integrating the module into the user model, and updating translations for password strength feedback in English, Spanish, and French. Minor localization improvements and code comments addressing registration issues are also included.Password Strength Validation Integration
devise_zxcvbnas a dependency inbetter_together.gemspecand required it inlib/better_together/engine.rbto enable password strength checking. [1] [2]:zxcvbnablemodule into theUsermodel via Devise to enforce strong password requirements.Internationalization and Localization
weak_passwordvalidation messages in English (config/locales/en.yml), Spanish (config/locales/es.yml), and French (config/locales/fr.yml) to provide clear feedback when a password is too weak. [1] [2] [3]Code Comments and Registration Flow
User#personmethod and a TODO block forweak_wordsto highlight potential save issues during registration due to automatic association building. [1] [2]