Feature/message opt in #955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Smith <[email protected]>
…olicy, people form, and en.yml conflicts keeping both message opt-in and conversation details toggles
…c; add request spec for participant list
…ors; add i18n; add model + request specs
…ipants for create/update; update request specs
…ing templates, improve participant filtering, and update localization for permitted participants.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
## Summary - raise `ActiveRecord::RecordNotFound` when accessing conversations not belonging to the current user - add request spec to ensure non-participants receive a 404 response ## Testing - `bin/dc-run bundle exec rubocop` *(fails: docker: command not found)* - `bin/codex_style_guard` *(fails: bundler: command not found: rubocop)* - `bin/dc-run bundle exec brakeman --quiet --no-pager` *(fails: docker: command not found)* - `bin/dc-run bundle exec bundler-audit --update` *(fails: docker: command not found)* - `bin/dc-run bin/i18n` *(fails: docker: command not found)* - `bin/dc-run bin/ci` *(fails: docker: command not found)* ------ https://chatgpt.com/codex/tasks/task_e_68b1f69223b88321bb27a78b2da20f6d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an opt-in mechanism for platform members to receive direct messages, tightening permissions around who can be added as participants in new or updated conversations. It centralizes participant permission logic, updates error handling and feedback, and adds localization for new messaging rules. The changes affect controller logic, model preferences, policy enforcement, user interface, and translations, ensuring members have explicit control over their messaging privacy.
Messaging Permissions & Participant Filtering:
receive_messages_from_memberspreference toBetterTogether::Person, defaulting to false, allowing members to opt in to receive messages from non-managers.ConversationPolicy#permitted_participants, restricting regular members to only message platform managers or opted-in members.ConversationsController#createand#updateto filter participant IDs using the new policy and provide error feedback if only disallowed participants are submitted. [1] [2] [3] [4]User Interface & Feedback:
Localization & Error Messaging:
Testing: